sc/source/ui/cctrl/checklistmenu.cxx | 6 +++++- sw/source/ui/fldui/fldref.cxx | 6 ++++++ 2 files changed, 11 insertions(+), 1 deletion(-)
New commits: commit e1ed35cb5c32c8e82e9f1a369cbaae6577b4cbc5 Author: Skyler Grey <[email protected]> AuthorDate: Wed Jan 7 11:38:56 2026 +0000 Commit: Szymon Kłos <[email protected]> CommitDate: Thu Jan 8 08:40:15 2026 +0100 feat(jsdialog): hide field reference search It's another core-side filter box. Similarly to the previous change (I40c2565920d1faf42e91d5b523a944776a6a6964) we would like to filter on the client Therefore, we need to hide the search bar here too Change-Id: Ibf524bcecdf7384bc068d4c21cb5608e6a6a6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/196726 Reviewed-by: Szymon Kłos <[email protected]> Tested-by: Szymon Kłos <[email protected]> diff --git a/sw/source/ui/fldui/fldref.cxx b/sw/source/ui/fldui/fldref.cxx index 7d10d2c1484f..28bd1f1f7fd5 100644 --- a/sw/source/ui/fldui/fldref.cxx +++ b/sw/source/ui/fldui/fldref.cxx @@ -110,6 +110,12 @@ SwFieldRefPage::SwFieldRefPage(weld::Container* pPage, weld::DialogController* p m_xTypeLB->clear(); + if (comphelper::LibreOfficeKit::isActive()) { + // In LOK (read: under JSDialog), it is preferable to run this search on + // the client side rather than in core for positioning/interference/etc. reasons + m_xFilterED->hide(); + } + m_xNameED->connect_changed(LINK(this, SwFieldRefPage, ModifyHdl)); m_xFilterED->connect_changed( LINK( this, SwFieldRefPage, ModifyHdl_Impl ) ); commit 4ed0bfc70f520428cd8d2d872cfe3ad98ccb8ec9 Author: Skyler Grey <[email protected]> AuthorDate: Mon Dec 15 16:57:47 2025 +0000 Commit: Szymon Kłos <[email protected]> CommitDate: Thu Jan 8 08:40:09 2026 +0100 feat(jsdialog): hide checklist menu search The checklist menu has a search bar here, which can be used to filter the items sent by LOK. In Collabora Online, we're changing over to a client-side search bar, which has advantages comprising: - Doing the filtering on the client is pretty easy - We can integrate it better into the listbox - We can expand it to more lists than just checkbox lists very easily If we do that, we shouldn't have the duplicate search bar. Let's remove it... Change-Id: I40c2565920d1faf42e91d5b523a944776a6a6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195719 Reviewed-by: Szymon Kłos <[email protected]> Tested-by: Szymon Kłos <[email protected]> diff --git a/sc/source/ui/cctrl/checklistmenu.cxx b/sc/source/ui/cctrl/checklistmenu.cxx index 6cad6816a342..9ee0de180da3 100644 --- a/sc/source/ui/cctrl/checklistmenu.cxx +++ b/sc/source/ui/cctrl/checklistmenu.cxx @@ -639,7 +639,11 @@ ScCheckListMenuControl::ScCheckListMenuControl(weld::Widget* pParent, ScViewData mxFieldsComboLabel->hide(); mxFieldsCombo->hide(); } - mxEdSearch->show(); + if (!comphelper::LibreOfficeKit::isActive()) { + // In LOK (read: under JSDialog), it is preferable to run this search on + // the client side rather than in core for positioning/interference/etc. reasons + mxEdSearch->show(); + } mxButtonBox->show(); mxMenu->connect_row_activated(LINK(this, ScCheckListMenuControl, RowActivatedHdl));
