chart2/source/view/main/ShapeFactory.cxx | 1 - compilerplugins/clang/reservedid.cxx | 10 +--------- 2 files changed, 1 insertion(+), 10 deletions(-)
New commits: commit 53e932da935212824e8e70bdfc3130f41b58ca6d Author: Stephan Bergmann <[email protected]> AuthorDate: Sun Jan 25 22:35:32 2026 +0100 Commit: Stephan Bergmann <[email protected]> CommitDate: Mon Jan 26 08:13:55 2026 +0100 -Werror,-Wunused-variable ...after 0e7de7e614cfc23f890abe370c3ec31d057b89c2 "tdf#167883 use appendTextPortion to construct svx text object" Change-Id: I3882d6a3852b4e4d30e3406ea5f0b2703afa8f8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198112 Reviewed-by: Stephan Bergmann <[email protected]> Tested-by: Jenkins diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx index ee1304074873..1d5fd9ce755c 100644 --- a/chart2/source/view/main/ShapeFactory.cxx +++ b/chart2/source/view/main/ShapeFactory.cxx @@ -2232,7 +2232,6 @@ rtl::Reference<SvxShapeText> // Lock during property update to prevent unnecessary layout work. xShape->addActionLock(); - uno::Reference< beans::XPropertySet > xSelectionProp(xSelectionCursor, uno::UNO_QUERY); if(bStackCharacters) { //if the characters should be stacked we use only the first character properties for code simplicity commit 28951381c6b881f89b855f42db5eaadb62b3bc20 Author: Stephan Bergmann <[email protected]> AuthorDate: Sun Jan 25 22:34:00 2026 +0100 Commit: Stephan Bergmann <[email protected]> CommitDate: Mon Jan 26 08:13:43 2026 +0100 No more need for ReservedId::isInLokIncludeFile special casing ...after 5bc9425900dac10c9c5ecbab881782b381b4225e "Avoid illegal names also for the LibreOfficeKitGtk structs" removed the remaining offenders Change-Id: I274486459dfc109c4d2e103d7ec41b0655657e77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198111 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <[email protected]> diff --git a/compilerplugins/clang/reservedid.cxx b/compilerplugins/clang/reservedid.cxx index a5daa439a7c2..03adeea87976 100644 --- a/compilerplugins/clang/reservedid.cxx +++ b/compilerplugins/clang/reservedid.cxx @@ -54,8 +54,6 @@ private: Kind determineKind(llvm::StringRef const & id); - bool isInLokIncludeFile(SourceLocation spellingLocation) const; - bool isApi(NamedDecl const * decl); }; @@ -282,12 +280,6 @@ ReservedId::Kind ReservedId::determineKind(llvm::StringRef const & id) { return Kind::Ok; } -bool ReservedId::isInLokIncludeFile(SourceLocation spellingLocation) const { - return loplugin::hasPathnamePrefix( - getFilenameOfLocation(spellingLocation), - SRCDIR "/include/LibreOfficeKit/"); -} - bool ReservedId::isApi(NamedDecl const * decl) { auto const fdecl = dyn_cast<FunctionDecl>(decl); if (fdecl != nullptr) { @@ -300,7 +292,7 @@ bool ReservedId::isApi(NamedDecl const * decl) { } auto const loc = compiler.getSourceManager().getSpellingLoc( decl->getLocation()); - if (!(isInUnoIncludeFile(loc) || isInLokIncludeFile(loc)) + if (!isInUnoIncludeFile(loc) || isa<ParmVarDecl>(decl)) { return false;
