Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1680657:       Incorrect expression  (BAD_COMPARE)
/sw/source/uibase/docvw/edtwin.cxx: 1323           in 
SwEditWin::ChangeDrawing(Move::Direction, Move::Size)()


_____________________________________________________________________________________________
*** CID 1680657:         Incorrect expression  (BAD_COMPARE)
/sw/source/uibase/docvw/edtwin.cxx: 1323             in 
SwEditWin::ChangeDrawing(Move::Direction, Move::Size)()
1317                 // if the object's position is not protected
1318                 if(!(nProtect&FlyProtectFlags::Pos))
1319                 {
1320                     // Check if object is anchored as character and move 
direction
1321                     bool bDummy1, bDummy2;
1322                     const bool bVertAnchor = rSh.IsFrameVertical( true, 
bDummy1, bDummy2 );
>>>     CID 1680657:         Incorrect expression  (BAD_COMPARE)
>>>     Comparing logical negation "!bVertAnchor" against "eDir == 
>>> Move::Direction::Left || eDir == Move::Direction::Right" is likely to be 
>>> incorrect.
1323                     bool bHoriMove = !bVertAnchor == (eDir == 
Move::Direction::Left || eDir == Move::Direction::Right);
1324                     bool bMoveAllowed =
1325                         !bHoriMove || (rSh.GetAnchorId() != 
RndStdIds::FLY_AS_CHAR);
1326                     if ( bMoveAllowed )
1327                     {
1328                         pSdrView->MoveAllMarked(Size(nX, nY));

** CID 1680656:       Uninitialized members  (UNINIT_CTOR)
/vcl/unx/gtk3/gtkinst.cxx: 13665           in 
<unnamed>::GtkInstanceTreeIter::GtkInstanceTreeIter(_GtkTreeModel *, const 
_GtkTreeIter *)()


_____________________________________________________________________________________________
*** CID 1680656:         Uninitialized members  (UNINIT_CTOR)
/vcl/unx/gtk3/gtkinst.cxx: 13665             in 
<unnamed>::GtkInstanceTreeIter::GtkInstanceTreeIter(_GtkTreeModel *, const 
_GtkTreeIter *)()
13659         {
13660             GtkInstanceTreeIter(GtkTreeModel* pTreeModel, const 
GtkTreeIter* pOrig)
13661                 : m_pTreeModel(pTreeModel)
13662             {
13663                 if (pOrig)
13664                     iter = *pOrig;
>>>     CID 1680656:         Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "iter.user_data3" is not initialized in this 
>>> constructor nor in any functions that it calls.
13665             }
13666     
13667             GtkInstanceTreeIter(GtkTreeModel* pTreeModel, const 
GtkTreeIter& rOrig)
13668                 : GtkInstanceTreeIter(pTreeModel, &rOrig)
13669             {
13670             }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, 
https://scan.coverity.com/projects/libreoffice?tab=overview

Reply via email to