sw/source/uibase/docvw/edtwin.cxx | 6 +++--- vcl/unx/gtk3/gtkinst.cxx | 3 +-- 2 files changed, 4 insertions(+), 5 deletions(-)
New commits: commit 92d2b40b62ba5bccf344f7610693d5937c8171db Author: Caolán McNamara <[email protected]> AuthorDate: Mon Jan 26 19:58:52 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Jan 26 22:27:48 2026 +0100 cid#1680657 silence Unintended comparison to logical negation Change-Id: I0f7d7d07d8c030a9d37c710b2a0eed1fc1326ea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/sw/source/uibase/docvw/edtwin.cxx b/sw/source/uibase/docvw/edtwin.cxx index e612bbf15eba..9c527c9f1976 100644 --- a/sw/source/uibase/docvw/edtwin.cxx +++ b/sw/source/uibase/docvw/edtwin.cxx @@ -1320,9 +1320,9 @@ void SwEditWin::ChangeDrawing(Move::Direction eDir, Move::Size eDirSize) // Check if object is anchored as character and move direction bool bDummy1, bDummy2; const bool bVertAnchor = rSh.IsFrameVertical( true, bDummy1, bDummy2 ); - bool bHoriMove = !bVertAnchor == (eDir == Move::Direction::Left || eDir == Move::Direction::Right); - bool bMoveAllowed = - !bHoriMove || (rSh.GetAnchorId() != RndStdIds::FLY_AS_CHAR); + const bool bIsHorizontalDirection = eDir == Move::Direction::Left || eDir == Move::Direction::Right; + const bool bHoriMove = bVertAnchor != bIsHorizontalDirection; + const bool bMoveAllowed = !bHoriMove || (rSh.GetAnchorId() != RndStdIds::FLY_AS_CHAR); if ( bMoveAllowed ) { pSdrView->MoveAllMarked(Size(nX, nY)); commit e3e5cd98618ef89b235515edab0eae609aadd664 Author: Caolán McNamara <[email protected]> AuthorDate: Mon Jan 26 19:47:52 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Jan 26 22:27:41 2026 +0100 cid#1680656 Uninitialized pointer field Change-Id: Ibabb1d675c9b3da95ef9eba32c95b7891fcbaf25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198168 Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index e8eb6fc8c7a7..be6f350d2150 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -13659,9 +13659,8 @@ namespace { GtkInstanceTreeIter(GtkTreeModel* pTreeModel, const GtkTreeIter* pOrig) : m_pTreeModel(pTreeModel) + , iter(pOrig ? *pOrig : GtkTreeIter{}) { - if (pOrig) - iter = *pOrig; } GtkInstanceTreeIter(GtkTreeModel* pTreeModel, const GtkTreeIter& rOrig)
