vcl/jsdialog/enabled.cxx | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-)
New commits: commit 56e3e0f8a2d28624aa6a94bd15c45639d68bc7e0 Author: Caolán McNamara <[email protected]> AuthorDate: Thu Jan 29 10:33:22 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Tue Feb 3 14:37:08 2026 +0100 add additional common sidebars to sidebar coverage Change-Id: I852c3c8f756be00e7d3e6f53b7424cb725b743a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198500 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Miklos Vajna <[email protected]> diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx index 2c3d5a879ab4..08fc5ba4ebfc 100644 --- a/vcl/jsdialog/enabled.cxx +++ b/vcl/jsdialog/enabled.cxx @@ -690,10 +690,30 @@ std::vector<OUString> completeCommonSidebarList(const o3tl::sorted_vector<OUStri { OUString sEntry(entry); - if (sEntry.startsWith("modules/")) + // consider schart and smath as 'common', but other modules specific to a toplevel application + if (sEntry.startsWith("modules/") && !sEntry.startsWith("modules/schart/") && !sEntry.startsWith("modules/smath/")) + continue; + //TODO: This one should be selectable, but that seems to be broken + else if (entry == u"modules/schart/ui/sidebarerrorbar.ui") + continue; + // Skip this one, it can't appear in practice + else if (entry == u"modules/smath/ui/sidebarproperties_math.ui") + continue; + // Skip this one, theme related, disabled at the moment + else if (entry == u"modules/schart/ui/sidebarcolors.ui") + continue; + // Skip this one, theme related, disabled at the moment + else if (entry == u"modules/schart/ui/sidebargradients.ui") + continue; + // Skip this one, theme related, disabled at the moment + else if (entry == u"modules/schart/ui/sidebartheme.ui") + continue; + // Skip this one, in practice it appears in draw/impress + // TODO: it should probably be made to appear in writer too + else if (entry == u"svx/ui/mediaplayback.ui") continue; // Skip this one, I don't think it can appear in practice - if (entry == u"svx/ui/sidebargallery.ui") + else if (entry == u"svx/ui/sidebargallery.ui") continue; // Skip this one, its context means it cannot appear in writer else if (entry == u"svx/ui/sidebarshadow.ui")
