vcl/qt5/QtInstanceToolbar.cxx | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-)
New commits: commit 972ead6227597b732e2e4559c2e7709f484d0d58 Author: Michael Weghorn <[email protected]> AuthorDate: Fri Feb 6 01:14:46 2026 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Feb 6 10:15:23 2026 +0100 tdf#130857 qt weld: Implement QtInstanceToolbar::set_item_visible Change-Id: I895d26aedb2ec18c83bed8177a7e0122b609f772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198806 Tested-by: Jenkins Reviewed-by: Michael Weghorn <[email protected]> diff --git a/vcl/qt5/QtInstanceToolbar.cxx b/vcl/qt5/QtInstanceToolbar.cxx index b1bce6e3f52c..df6d054621e1 100644 --- a/vcl/qt5/QtInstanceToolbar.cxx +++ b/vcl/qt5/QtInstanceToolbar.cxx @@ -100,9 +100,15 @@ void QtInstanceToolbar::set_item_popover(const OUString&, weld::Widget*) assert(false && "Not implemented yet"); } -void QtInstanceToolbar::set_item_visible(const OUString&, bool) +void QtInstanceToolbar::set_item_visible(const OUString& rIdent, bool bVisible) { - assert(false && "Not implemented yet"); + SolarMutexGuard g; + + GetQtInstance().RunInMainThread([&] { + QToolButton* pToolButton = m_pToolBar->findChild<QToolButton*>(toQString(rIdent)); + assert(pToolButton && "No tool button with the given ID found"); + pToolButton->setVisible(bVisible); + }); } void QtInstanceToolbar::set_item_help_id(const OUString&, const OUString&) commit 1c3fb472fe25e19ca20a6c54a4a48a325ce8a614 Author: Michael Weghorn <[email protected]> AuthorDate: Fri Feb 6 01:08:46 2026 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Feb 6 10:15:17 2026 +0100 tdf#130857 qt weld: Implement QtInstanceToolbar::get_n_items Change-Id: I92fc9421f65d62d48b008d303c458c0f662bb8cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198805 Reviewed-by: Michael Weghorn <[email protected]> Tested-by: Jenkins diff --git a/vcl/qt5/QtInstanceToolbar.cxx b/vcl/qt5/QtInstanceToolbar.cxx index d3789a0728bc..b1bce6e3f52c 100644 --- a/vcl/qt5/QtInstanceToolbar.cxx +++ b/vcl/qt5/QtInstanceToolbar.cxx @@ -204,8 +204,12 @@ void QtInstanceToolbar::insert_separator(int, const OUString&) int QtInstanceToolbar::get_n_items() const { - assert(false && "Not implemented yet"); - return 0; + SolarMutexGuard g; + + int nItemCount = 0; + GetQtInstance().RunInMainThread([&] { nItemCount = m_pToolBar->actions().count(); }); + + return nItemCount; } OUString QtInstanceToolbar::get_item_ident(int) const commit ad5f66d265a1e9f6fcc47647862de05a39b3fc72 Author: Michael Weghorn <[email protected]> AuthorDate: Fri Feb 6 00:54:27 2026 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Feb 6 10:15:10 2026 +0100 tdf#130857 qt weld a11y: Implement QtInstanceToolbar::set_item_accessible_name In a WIP branch where support for using native Qt widgets is declared for sidebar elements, this e.g. makes the a11y name show up as expected for the "Properties" button etc. (Sidebar not supported yet with native Qt widgets, but this is one step in that direction at least.) Change-Id: Id737543ca71b2509c87f181fafee0a58001d4eb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/198804 Reviewed-by: Michael Weghorn <[email protected]> Tested-by: Jenkins diff --git a/vcl/qt5/QtInstanceToolbar.cxx b/vcl/qt5/QtInstanceToolbar.cxx index 5a62f87f4998..d3789a0728bc 100644 --- a/vcl/qt5/QtInstanceToolbar.cxx +++ b/vcl/qt5/QtInstanceToolbar.cxx @@ -239,9 +239,15 @@ void QtInstanceToolbar::set_item_accessible_name(int, const OUString&) assert(false && "Not implemented yet"); } -void QtInstanceToolbar::set_item_accessible_name(const OUString&, const OUString&) +void QtInstanceToolbar::set_item_accessible_name(const OUString& rIdent, const OUString& rName) { - assert(false && "Not implemented yet"); + SolarMutexGuard g; + + GetQtInstance().RunInMainThread([&] { + QToolButton* pToolButton = m_pToolBar->findChild<QToolButton*>(toQString(rIdent)); + assert(pToolButton && "No tool button with the given ID found"); + pToolButton->setAccessibleName(toQString(rName)); + }); } vcl::ImageType QtInstanceToolbar::get_icon_size() const
