On Tuesday 18 of September 2012, Stephan Bergmann wrote: > On 07/16/2012 04:03 PM, Lubos Lunak wrote: > > FYI, this is now in. The stable modules (sal/, salhelper/, cppu/, > > cppuhelper/) build without it and there's additionally a check including > > all their .hxx's to verify them. The rest of LO can now use > > OUString&friends without the explicit rtl. > > It turns out that one drawback of this is with header files that are > careful to only declare the incomplete type via > > namespace rtl { class OUString; } > > (instead of including rtl/ustring.hxx) if that is all they need. They > would either need to continue using "rtl::OUString" (instead of just > "OUString"), or need to duplicate the using declaration (which could be > considered breaking of encapsulation), or include rtl/ustring.hxx instead.
Is there any practical reason not to include rtl/ustring.hxx? I'd say that the file eventually ends up included by pretty much all .cxx files, so a forward declaration of such a basic class does not gain anything. -- Lubos Lunak l.lu...@suse.cz _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice