Hi there,
Thanks for the updated patch :-)
On Mon, 2012-12-10 at 08:08 -0800, Christos Strubulis wrote:
> I haven't deleted helpcontent2 yet but I will do it before the
> next autogen and compilation.
I removed it from the patch and pushed.
> Would you like to have a look at the attached patch? What is
> your opinion now?
Lubos asked you to:
> > - SAL_CALL is already defined in sal/inc/sal/types.h , so there's no need
> > to
> > define it again in tools/inc/tools/solar.h , the definition of
> > __LOADONCALLAPI should be simply removed there
> >
> > Can you submit a new patch with these changes ?
I did that for you, since your patch still had the definition of
SAL_CALL included - did you send the wrong patch somehow ?
Anyhow - thanks for your first contribution; good to get it in.
All the best,
Michael.
--
michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
