At least current Clang towards 3.4 fails on current master with
/home/sbergman/lo-clang/core/vcl/headless/svptext.cxx:175:40: error: comparison
between pointer and integer ('void *' and 'sal_Int32' (aka 'int'))
if( rGlyphData.ExtDataRef().mpData != Format::NONE )
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~
The code of SvpGlyphPeer::RemovingGlyph appears to be that way since its
inception in
<http://cgit.freedesktop.org/libreoffice/core/commit/?id=b6801926b515be4cfb10ca7e3322939f0f97426b>
"INTEGRATION: CWS mergesvp (1.1.2); FILE ADDED." Given that
basebmp::Format::NONE is
static const sal_Int32 NONE = 0;
that might either be a bad way of checking
rGlyphData.ExtDataRef().mpData is non-null that just happens to work out
as intended, or might be a broken attempt at checking that
rGlyphData.ExtDataRef().meInfo is not Format::NONE.
Anybody an idea what might be the better interpretation?
Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
