connectivity/source/drivers/dbase/DIndex.cxx | 28 ++++++---- connectivity/source/drivers/dbase/DTable.cxx | 41 +++++++------- connectivity/source/drivers/file/FConnection.cxx | 16 +++-- connectivity/source/inc/OColumn.hxx | 18 ++++++ connectivity/source/inc/OTypeInfo.hxx | 12 +--- connectivity/source/inc/odbc/OBoundParam.hxx | 1 cui/source/tabpages/backgrnd.cxx | 31 +++++++---- dbaccess/source/core/api/RowSet.cxx | 2 dbaccess/source/ext/macromigration/rangeprogressbar.hxx | 12 ++-- dbaccess/source/filter/xml/xmlStyleImport.cxx | 27 +++++---- dbaccess/source/filter/xml/xmlStyleImport.hxx | 2 dbaccess/source/filter/xml/xmlfilter.cxx | 5 + dbaccess/source/ui/inc/TableCopyHelper.hxx | 8 ++ dbaccess/source/ui/inc/TokenWriter.hxx | 3 - dbaccess/source/ui/inc/WTypeSelect.hxx | 12 +++- dbaccess/source/ui/misc/HtmlReader.cxx | 26 +++++---- dbaccess/source/ui/querydesign/QTableConnection.cxx | 7 +- dbaccess/source/ui/querydesign/QTableConnectionData.cxx | 44 ++++++++-------- dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx | 5 + dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx | 2 20 files changed, 179 insertions(+), 123 deletions(-)
New commits: commit 6ebd7992ae774c7eb96b55c1cf39fbd922f66878 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 15:05:32 2014 -0600 coverity#707743 : Uninitialized scalar field Change-Id: I80661c2b88b7c10175e4622db7e843699d6c1686 diff --git a/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx b/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx index ea760d1..8dfdbc7 100644 --- a/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx +++ b/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.cxx @@ -40,8 +40,9 @@ OQueryDesignFieldUndoAct::~OQueryDesignFieldUndoAct() } OQueryTabWinUndoAct::OQueryTabWinUndoAct(OQueryTableView* pOwner, sal_uInt16 nCommentID) - :OQueryDesignUndoAction(pOwner, nCommentID) - ,m_pTabWin(NULL) + : OQueryDesignUndoAction(pOwner, nCommentID) + , m_pTabWin(NULL) + , m_bOwnerOfObjects(sal_False) { } diff --git a/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx b/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx index 77436e7..676c433 100644 --- a/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx +++ b/dbaccess/source/ui/querydesign/QueryTabWinUndoAct.hxx @@ -35,7 +35,7 @@ namespace dbaui protected: ::std::vector<OTableConnection*> m_vTableConnection; OQueryTableWindow* m_pTabWin; - sal_Bool m_bOwnerOfObjects; + sal_Bool m_bOwnerOfObjects; // am I the only owner of the managed objects? (changes with every redo or undo) public: commit 4a169e4203c10ec8f76b9bcb33882c82b65c7bab Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 15:01:25 2014 -0600 coverity#707742 : Uninitialized scalar field Change-Id: I52bc7ec4326e212a93df3be9b2232bac584d9ee0 diff --git a/dbaccess/source/ui/querydesign/QTableConnectionData.cxx b/dbaccess/source/ui/querydesign/QTableConnectionData.cxx index 81f53ba..5167d8a 100644 --- a/dbaccess/source/ui/querydesign/QTableConnectionData.cxx +++ b/dbaccess/source/ui/querydesign/QTableConnectionData.cxx @@ -25,34 +25,38 @@ using namespace dbaui; // class OQueryTableConnectionData OQueryTableConnectionData::OQueryTableConnectionData() - :OTableConnectionData() - ,m_eJoinType (INNER_JOIN) - ,m_bNatural(false) + : OTableConnectionData() + , m_nFromEntryIndex(0) + , m_nDestEntryIndex(0) + , m_eJoinType (INNER_JOIN) + , m_bNatural(false) + , m_eFromType(TAB_NORMAL_FIELD) + , m_eDestType(TAB_NORMAL_FIELD) { } OQueryTableConnectionData::OQueryTableConnectionData( const OQueryTableConnectionData& rConnData ) - :OTableConnectionData( rConnData ) + : OTableConnectionData( rConnData ) + , m_nFromEntryIndex(rConnData.m_nFromEntryIndex) + , m_nDestEntryIndex(rConnData.m_nDestEntryIndex) + , m_eJoinType(rConnData.m_eJoinType) + , m_bNatural(rConnData.m_bNatural) + , m_eFromType(rConnData.m_eFromType) + , m_eDestType(rConnData.m_eDestType) { - m_nFromEntryIndex = rConnData.m_nFromEntryIndex; - m_nDestEntryIndex = rConnData.m_nDestEntryIndex; - m_eFromType = rConnData.m_eFromType; - m_eDestType = rConnData.m_eDestType; - m_eJoinType = rConnData.m_eJoinType; - m_bNatural = rConnData.m_bNatural; } -OQueryTableConnectionData::OQueryTableConnectionData(const TTableWindowData::value_type& _pReferencingTable - ,const TTableWindowData::value_type& _pReferencedTable - ,const OUString& rConnName) - :OTableConnectionData( _pReferencingTable,_pReferencedTable, rConnName ) - ,m_nFromEntryIndex(0) - ,m_nDestEntryIndex(0) - ,m_eJoinType (INNER_JOIN) - ,m_bNatural(false) - ,m_eFromType(TAB_NORMAL_FIELD) - ,m_eDestType(TAB_NORMAL_FIELD) +OQueryTableConnectionData::OQueryTableConnectionData(const TTableWindowData::value_type& _pReferencingTable, + const TTableWindowData::value_type& _pReferencedTable, + const OUString& rConnName) + : OTableConnectionData( _pReferencingTable,_pReferencedTable, rConnName ) + , m_nFromEntryIndex(0) + , m_nDestEntryIndex(0) + , m_eJoinType (INNER_JOIN) + , m_bNatural(false) + , m_eFromType(TAB_NORMAL_FIELD) + , m_eDestType(TAB_NORMAL_FIELD) { } commit 74fe7a96aaa00dab580510c162a4373cb811146f Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:55:57 2014 -0600 coverity#707741 : Uninitialized scalar field Change-Id: I1165102386aa5f6a9a35613ef199a1a5caad4ce3 diff --git a/dbaccess/source/ui/querydesign/QTableConnection.cxx b/dbaccess/source/ui/querydesign/QTableConnection.cxx index 879bdae..0663bb6 100644 --- a/dbaccess/source/ui/querydesign/QTableConnection.cxx +++ b/dbaccess/source/ui/querydesign/QTableConnection.cxx @@ -25,13 +25,14 @@ using namespace dbaui; // class OQueryTableConnection OQueryTableConnection::OQueryTableConnection(OQueryTableView* pContainer, const TTableConnectionData::value_type& pTabConnData) - :OTableConnection(pContainer, pTabConnData) - ,m_bVisited(sal_False) + : OTableConnection(pContainer, pTabConnData) + , m_bVisited(sal_False) { } OQueryTableConnection::OQueryTableConnection(const OQueryTableConnection& rConn) - :OTableConnection( rConn ) + : OTableConnection( rConn ) + , m_bVisited(sal_False) { // no own members, so base class functionality is sufficient } commit e9ae8e42562a76fdbad3f42a021e1adec81099d8 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:54:28 2014 -0600 coverity#707737-38 : Uninitialized scalar field Change-Id: Ifb3704f73835886d4c27b6cd59bb918576e0f1ac diff --git a/dbaccess/source/ui/misc/HtmlReader.cxx b/dbaccess/source/ui/misc/HtmlReader.cxx index e2755b4..dcb03ea 100644 --- a/dbaccess/source/ui/misc/HtmlReader.cxx +++ b/dbaccess/source/ui/misc/HtmlReader.cxx @@ -72,12 +72,13 @@ OHTMLReader::OHTMLReader(SvStream& rIn,const SharedConnection& _rxConnection, const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext, const TColumnVector* pList, const OTypeInfoMap* _pInfoMap) - :HTMLParser(rIn) - ,ODatabaseExport( _rxConnection, _rxNumberF, _rxContext, pList, _pInfoMap, rIn ) - ,m_nTableCount(0) - ,m_nColumnWidth(87) - ,m_bMetaOptions(sal_False) - ,m_bSDNum(sal_False) + : HTMLParser(rIn) + , ODatabaseExport( _rxConnection, _rxNumberF, _rxContext, pList, _pInfoMap, rIn ) + , m_nTableCount(0) + , m_nWidth(0) + , m_nColumnWidth(87) + , m_bMetaOptions(sal_False) + , m_bSDNum(sal_False) { SAL_INFO("dbaccess.ui", "OHTMLReader::OHTMLReader" ); SetSrcEncoding( GetExtendedCompatibilityTextEncoding( RTL_TEXTENCODING_ISO_8859_1 ) ); @@ -93,12 +94,13 @@ OHTMLReader::OHTMLReader(SvStream& rIn, const TColumnVector* pList, const OTypeInfoMap* _pInfoMap, sal_Bool _bAutoIncrementEnabled) - :HTMLParser(rIn) - ,ODatabaseExport( nRows, _rColumnPositions, _rxNumberF, _rxContext, pList, _pInfoMap, _bAutoIncrementEnabled, rIn ) - ,m_nTableCount(0) - ,m_nColumnWidth(87) - ,m_bMetaOptions(sal_False) - ,m_bSDNum(sal_False) + : HTMLParser(rIn) + , ODatabaseExport( nRows, _rColumnPositions, _rxNumberF, _rxContext, pList, _pInfoMap, _bAutoIncrementEnabled, rIn ) + , m_nTableCount(0) + , m_nWidth(0) + , m_nColumnWidth(87) + , m_bMetaOptions(sal_False) + , m_bSDNum(sal_False) { SAL_INFO("dbaccess.ui", "OHTMLReader::OHTMLReader" ); SetSrcEncoding( GetExtendedCompatibilityTextEncoding( RTL_TEXTENCODING_ISO_8859_1 ) ); commit c63034aff9050adc90dfa3ed5fcbd35e90a5d65a Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:49:14 2014 -0600 coverity#707736 : Uninitialized scalar field Change-Id: Iab4b7e52d2a3a77589341d8956a8a835163c7bc5 diff --git a/dbaccess/source/ui/inc/WTypeSelect.hxx b/dbaccess/source/ui/inc/WTypeSelect.hxx index b7f66d0..fd9e2b5 100644 --- a/dbaccess/source/ui/inc/WTypeSelect.hxx +++ b/dbaccess/source/ui/inc/WTypeSelect.hxx @@ -65,12 +65,18 @@ namespace dbaui sal_Bool IsPrimaryKeyAllowed() const; void setPrimaryKey( OFieldDescription* _pFieldDescr, sal_uInt16 _nPos, - sal_Bool _bSet=sal_False); + sal_Bool _bSet = sal_False); protected: virtual bool PreNotify( NotifyEvent& rNEvt ); public: - OWizTypeSelectList( Window* pParent, WinBits nStyle = WB_BORDER ) : MultiListBox(pParent,nStyle) {}; - OWizTypeSelectList( Window* pParent, const ResId& rResId ) : MultiListBox(pParent,rResId) {}; + OWizTypeSelectList( Window* pParent, WinBits nStyle = WB_BORDER ) + : MultiListBox(pParent,nStyle) + , m_bPKey(sal_False) + {} + OWizTypeSelectList( Window* pParent, const ResId& rResId ) + : MultiListBox(pParent,rResId) + , m_bPKey(sal_False) + {} void SetPKey(sal_Bool bPKey) { m_bPKey = bPKey; } }; commit 42fae6e07b8758a3f8a27d315b50dd6b8c28b26f Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:46:57 2014 -0600 coverity#707735 : Uninitialized scalar field Change-Id: Ie34247ba1d0b9b10183897c4fab0a7b10c0576b5 diff --git a/dbaccess/source/ui/inc/TokenWriter.hxx b/dbaccess/source/ui/inc/TokenWriter.hxx index 32d9538..e6df621 100644 --- a/dbaccess/source/ui/inc/TokenWriter.hxx +++ b/dbaccess/source/ui/inc/TokenWriter.hxx @@ -179,7 +179,8 @@ namespace dbaui OHTMLImportExport( const SharedConnection& _rxConnection, const ::com::sun::star::uno::Reference< ::com::sun::star::util::XNumberFormatter >& _rxNumberF, const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rM) - : ODatabaseImportExport(_rxConnection,_rxNumberF,_rM) + : ODatabaseImportExport(_rxConnection,_rxNumberF,_rM) + , m_nIndent(0) {} virtual sal_Bool Write(); commit 08a35a1460be40059219e96f489c56e1264ab59f Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:44:44 2014 -0600 coverity#707734 : Uninitialized scalar field Change-Id: Ic2333fbdcbd3265185f382c947166e6580050ff5 diff --git a/dbaccess/source/ui/inc/TableCopyHelper.hxx b/dbaccess/source/ui/inc/TableCopyHelper.hxx index c89a705..127567a 100644 --- a/dbaccess/source/ui/inc/TableCopyHelper.hxx +++ b/dbaccess/source/ui/inc/TableCopyHelper.hxx @@ -82,7 +82,13 @@ namespace dbaui sal_Bool bHtml; sal_Bool bError; - DropDescriptor() : nType(E_TABLE),pDroppedAt(NULL),nAction(DND_ACTION_NONE) { } + DropDescriptor() + : nType(E_TABLE) + , pDroppedAt(NULL) + , nAction(DND_ACTION_NONE) + , bHtml(sal_False) + , bError(sal_False) + { } }; OTableCopyHelper(OGenericUnoController* _pControler); commit 9740a2af05e1042d737c62b42a7028889e2ceaf3 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:42:02 2014 -0600 coverity#707731 : Uninitialized scalar field Change-Id: I048ad8477df070dd77a36620ea239fcd8bd9da60 diff --git a/dbaccess/source/filter/xml/xmlfilter.cxx b/dbaccess/source/filter/xml/xmlfilter.cxx index b325e34..509200a 100644 --- a/dbaccess/source/filter/xml/xmlfilter.cxx +++ b/dbaccess/source/filter/xml/xmlfilter.cxx @@ -346,8 +346,9 @@ sal_Int32 ReadThroughComponent( // - ODBFilter - ODBFilter::ODBFilter( const uno::Reference< XComponentContext >& _rxContext ) - :SvXMLImport(_rxContext, getImplementationName_Static()) - ,m_bNewFormat(false) + : SvXMLImport(_rxContext, getImplementationName_Static()) + , m_nPreviewMode(0) + , m_bNewFormat(false) { GetMM100UnitConverter().SetCoreMeasureUnit(util::MeasureUnit::MM_10TH); commit d9e0c297cee589a05d9e38d97465324ae26ea8f3 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:35:25 2014 -0600 coverity#707730 : Uninitialized scalar field Change-Id: Iaf0d1bd80d0d27f61790fc716f2ad3faed048a5a diff --git a/dbaccess/source/filter/xml/xmlStyleImport.cxx b/dbaccess/source/filter/xml/xmlStyleImport.cxx index 8d00021..4c5337a 100644 --- a/dbaccess/source/filter/xml/xmlStyleImport.cxx +++ b/dbaccess/source/filter/xml/xmlStyleImport.cxx @@ -141,16 +141,17 @@ ODBFilter& OTableStyleContext::GetOwnImport() OTableStylesContext::OTableStylesContext( SvXMLImport& rImport, - sal_uInt16 nPrfx , - const OUString& rLName , - const Reference< XAttributeList > & xAttrList, - const sal_Bool bTempAutoStyles ) : - SvXMLStylesContext( rImport, nPrfx, rLName, xAttrList ), - sTableStyleServiceName( OUString( XML_STYLE_FAMILY_TABLE_TABLE_STYLES_NAME )), - sColumnStyleServiceName( OUString( XML_STYLE_FAMILY_TABLE_COLUMN_STYLES_NAME )), - sCellStyleServiceName( OUString( XML_STYLE_FAMILY_TABLE_CELL_STYLES_NAME )), - m_nNumberFormatIndex(-1), - bAutoStyles(bTempAutoStyles) + sal_uInt16 nPrfx , + const OUString& rLName , + const Reference< XAttributeList > & xAttrList, + const sal_Bool bTempAutoStyles ) + : SvXMLStylesContext( rImport, nPrfx, rLName, xAttrList ) + , sTableStyleServiceName( OUString( XML_STYLE_FAMILY_TABLE_TABLE_STYLES_NAME )) + , sColumnStyleServiceName( OUString( XML_STYLE_FAMILY_TABLE_COLUMN_STYLES_NAME )) + , sCellStyleServiceName( OUString( XML_STYLE_FAMILY_TABLE_CELL_STYLES_NAME )) + , m_nNumberFormatIndex(-1) + , m_nMasterPageNameIndex(-1) + , bAutoStyles(bTempAutoStyles) { } @@ -269,10 +270,10 @@ sal_Int32 OTableStylesContext::GetIndex(const sal_Int16 nContextID) } else if ( nContextID == CTF_DB_MASTERPAGENAME ) { - if (nMasterPageNameIndex == -1) - nMasterPageNameIndex = + if (m_nMasterPageNameIndex == -1) + m_nMasterPageNameIndex = GetImportPropertyMapper(XML_STYLE_FAMILY_TABLE_TABLE)->getPropertySetMapper()->FindEntryIndex(nContextID); - return nMasterPageNameIndex; + return m_nMasterPageNameIndex; } else return -1; diff --git a/dbaccess/source/filter/xml/xmlStyleImport.hxx b/dbaccess/source/filter/xml/xmlStyleImport.hxx index a9fee3b..078946b 100644 --- a/dbaccess/source/filter/xml/xmlStyleImport.hxx +++ b/dbaccess/source/filter/xml/xmlStyleImport.hxx @@ -80,7 +80,7 @@ namespace dbaxml const OUString sColumnStyleServiceName; const OUString sCellStyleServiceName; sal_Int32 m_nNumberFormatIndex; - sal_Int32 nMasterPageNameIndex; + sal_Int32 m_nMasterPageNameIndex; sal_Bool bAutoStyles : 1; mutable UniReference < SvXMLImportPropertyMapper > m_xTableImpPropMapper; commit 620ddc9eaf2d6cffc02c85e2b92218885c019217 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:28:35 2014 -0600 coverity#707729 : Uninitialized scalar field Change-Id: I4411b8d36a184391e2be2be9be82016958607fda diff --git a/dbaccess/source/ext/macromigration/rangeprogressbar.hxx b/dbaccess/source/ext/macromigration/rangeprogressbar.hxx index 90ef55c..f7d231d 100644 --- a/dbaccess/source/ext/macromigration/rangeprogressbar.hxx +++ b/dbaccess/source/ext/macromigration/rangeprogressbar.hxx @@ -32,14 +32,14 @@ namespace dbmm { public: RangeProgressBar( Window* _pParent, WinBits nWinBits = WB_STDPROGRESSBAR ) - :ProgressBar( _pParent, nWinBits ) - { - } + : ProgressBar( _pParent, nWinBits ) + , m_nRange(0) + { } RangeProgressBar( Window* _pParent, const ResId& rResId ) - :ProgressBar( _pParent, rResId ) - { - } + : ProgressBar( _pParent, rResId ) + , m_nRange(0) + { } inline void SetRange( sal_uInt32 _nRange ); inline sal_uInt32 GetRange() const; commit c2b50457efd1acf005a10157c6f79186c30eb07d Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:25:30 2014 -0600 coverity#707725 : Uninitialized scalar field Change-Id: Ia5ebaca5bbb35946250854abf78ab9ab2041757f diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx index 7cbb193..5e5af3f 100644 --- a/dbaccess/source/core/api/RowSet.cxx +++ b/dbaccess/source/core/api/RowSet.cxx @@ -143,7 +143,9 @@ ORowSet::ORowSet( const Reference< ::com::sun::star::uno::XComponentContext >& _ ,m_nCommandType(CommandType::COMMAND) ,m_nTransactionIsolation(0) ,m_nPrivileges(0) + ,m_nLastKnownRowCount(0) ,m_nInAppend(0) + ,m_bLastKnownRowCountFinal(sal_False) ,m_bUseEscapeProcessing(sal_True) ,m_bApplyFilter(sal_False) ,m_bCommandFacetsDirty( sal_True ) commit 1e7dbe747e747d69516b238fa25d72b25e89776c Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:18:49 2014 -0600 coverity#707724 : Uninitialized scalar field Change-Id: I5514f0906d01f3a05a145a9f45ba2a599f85b26c diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx index 8a20479..d7c5439 100644 --- a/cui/source/tabpages/backgrnd.cxx +++ b/cui/source/tabpages/backgrnd.cxx @@ -72,14 +72,20 @@ struct SvxBackgroundTable_Impl SvxBrushItem* pCellBrush; SvxBrushItem* pRowBrush; SvxBrushItem* pTableBrush; - sal_uInt16 nCellWhich; - sal_uInt16 nRowWhich; - sal_uInt16 nTableWhich; - sal_uInt16 nActPos; - - SvxBackgroundTable_Impl() : - pCellBrush(NULL), pRowBrush(NULL), pTableBrush(NULL), - nCellWhich(0), nRowWhich(0), nTableWhich(0) {} + sal_uInt16 nCellWhich; + sal_uInt16 nRowWhich; + sal_uInt16 nTableWhich; + sal_uInt16 nActPos; + + SvxBackgroundTable_Impl() + : pCellBrush(NULL) + , pRowBrush(NULL) + , pTableBrush(NULL) + , nCellWhich(0) + , nRowWhich(0) + , nTableWhich(0) + , nActPos(0) + {} }; struct SvxBackgroundPara_Impl @@ -94,15 +100,18 @@ struct SvxBackgroundPara_Impl , pCharBrush(NULL) , nActPos(LISTBOX_ENTRY_NOTFOUND) {} + }; struct SvxBackgroundPage_Impl { Timer* pLoadTimer; - sal_Bool bIsImportDlgInExecute; + sal_Bool bIsImportDlgInExecute; - SvxBackgroundPage_Impl() : - pLoadTimer(NULL), bIsImportDlgInExecute(sal_False) {} + SvxBackgroundPage_Impl() + : pLoadTimer(NULL) + , bIsImportDlgInExecute(sal_False) + {} }; static inline sal_uInt8 lcl_PercentToTransparency(long nPercent) commit fce501877738c55044d28dbab2765295301dfccd Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:15:01 2014 -0600 coverity#707709 : Uninitialized scalar field Change-Id: I65d3a65c67467338bc8a4b1d03d859fc079613c3 diff --git a/connectivity/source/inc/odbc/OBoundParam.hxx b/connectivity/source/inc/odbc/OBoundParam.hxx index fca532b..d39ba14 100644 --- a/connectivity/source/inc/odbc/OBoundParam.hxx +++ b/connectivity/source/inc/odbc/OBoundParam.hxx @@ -33,6 +33,7 @@ namespace connectivity public: OBoundParam() : binaryData(NULL) + , paramLength(0) , paramInputStreamLen(0) , sqlType(::com::sun::star::sdbc::DataType::SQLNULL) , outputParameter(false) commit b4f275f32ef715daedb0db4085096fa22f80ce13 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 14:12:38 2014 -0600 coverity#707708 : Uninitialized scalar field Change-Id: I5bcb4a1b23c67546c247747c883f0d5dafda3896 diff --git a/connectivity/source/inc/OTypeInfo.hxx b/connectivity/source/inc/OTypeInfo.hxx index 754f791..ae29318 100644 --- a/connectivity/source/inc/OTypeInfo.hxx +++ b/connectivity/source/inc/OTypeInfo.hxx @@ -43,13 +43,11 @@ namespace connectivity sal_Int16 nSearchType; // Can we search for the type? sal_Int16 nNumPrecRadix; // indicating the radix, which is usually 2 or 10 - sal_Bool bCurrency : 1, // Currency - bAutoIncrement : 1, // Is it an autoincrementing field? - bNullable : 1, // Can the field be NULL? - bCaseSensitive : 1, // Is the type case sensitive? - bUnsigned : 1, // Is the type unsigned? - bEmpty_1 : 1, // for later use - bEmpty_2 : 1; + sal_Bool bCurrency : 1; // Currency + sal_Bool bAutoIncrement : 1; // Is it an autoincrementing field? + sal_Bool bNullable : 1; // Can the field be NULL? + sal_Bool bCaseSensitive : 1; // Is the type case sensitive? + sal_Bool bUnsigned : 1; // Is the type unsigned? OTypeInfo() :nPrecision(0) commit 4682bdd39d2e74efcc67dc08fa8ec47f730b8782 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 13:58:37 2014 -0600 coverity#707707 : Uninitialized scalar field Change-Id: I45fd57dcb3a02290287552e05dbfb6d44d944731 diff --git a/connectivity/source/inc/OColumn.hxx b/connectivity/source/inc/OColumn.hxx index 479762d..6a68e8a 100644 --- a/connectivity/source/inc/OColumn.hxx +++ b/connectivity/source/inc/OColumn.hxx @@ -52,7 +52,23 @@ namespace connectivity sal_Bool m_DefinitelyWritable; public: - OColumn() {} + OColumn() + : m_Nullable(0) + , m_ColumnDisplaySize(0) + , m_Precision(0) + , m_Scale(0) + , m_ColumnType(0) + + , m_AutoIncrement(sal_False) + , m_CaseSensitive(sal_False) + , m_Searchable(sal_True) + , m_Currency(sal_False) + , m_Signed(sal_False) + , m_ReadOnly(sal_True) + , m_Writable(sal_False) + , m_DefinitelyWritable(sal_False) + {} + OColumn(const OUString &_aTableName, const OUString &_aColumnName, commit ba71cfb7e1dd011f6205b247816fc08f038333b4 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 13:37:48 2014 -0600 coverity#707694 : Uninitialized scalar field Change-Id: I77c5e82c64dd8385a75f4b0eaf9d412e94534e6d diff --git a/connectivity/source/drivers/file/FConnection.cxx b/connectivity/source/drivers/file/FConnection.cxx index 3b37bec..0523759 100644 --- a/connectivity/source/drivers/file/FConnection.cxx +++ b/connectivity/source/drivers/file/FConnection.cxx @@ -56,13 +56,15 @@ using namespace ::ucbhelper; typedef connectivity::OMetaConnection OConnection_BASE; // -------------------------------------------------------------------------------- OConnection::OConnection(OFileDriver* _pDriver) - : OSubComponent<OConnection, OConnection_BASE>((::cppu::OWeakObject*)_pDriver, this) - ,m_pDriver(_pDriver) - ,m_bClosed(sal_False) - ,m_bShowDeleted(sal_False) - ,m_bCaseSensitiveExtension( sal_True ) - ,m_bCheckSQL92(sal_False) - ,m_bDefaultTextEncoding(false) + : OSubComponent<OConnection, OConnection_BASE>((::cppu::OWeakObject*)_pDriver, this) + , m_pDriver(_pDriver) + , m_bClosed(sal_False) + , m_bAutoCommit(sal_False) + , m_bReadOnly(sal_False) + , m_bShowDeleted(sal_False) + , m_bCaseSensitiveExtension( sal_True ) + , m_bCheckSQL92(sal_False) + , m_bDefaultTextEncoding(false) { m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; } commit 5323a5a587f5b9ac0165f0023192a368383c420f Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 13:26:07 2014 -0600 coverity#707692-93 : Uninitialized scalar field Change-Id: I72f1e29ef4f5e8af1e3bd300bc2604396080912c diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx index dc0ba14..d38b151 100644 --- a/connectivity/source/drivers/dbase/DTable.cxx +++ b/connectivity/source/drivers/dbase/DTable.cxx @@ -440,35 +440,34 @@ void ODbaseTable::fillColumns() OSL_ENSURE(i,"No columns in table!"); } // ------------------------------------------------------------------------- -ODbaseTable::ODbaseTable(sdbcx::OCollection* _pTables,ODbaseConnection* _pConnection) - :ODbaseTable_BASE(_pTables,_pConnection) - ,m_pMemoStream(NULL) - ,m_bWriteableMemo(sal_False) +ODbaseTable::ODbaseTable(sdbcx::OCollection* _pTables, ODbaseConnection* _pConnection) + : ODbaseTable_BASE(_pTables,_pConnection) + , m_pMemoStream(NULL) + , m_bWriteableMemo(sal_False) { SAL_INFO( "connectivity.drivers", "dbase ocke.jans...@sun.com ODbaseTable::ODbaseTable" ); // initialize the header - m_aHeader.db_typ = dBaseIII; - m_aHeader.db_anz = 0; - m_aHeader.db_kopf = 0; - m_aHeader.db_slng = 0; + m_aHeader = {}; + m_aHeader.db_typ = dBaseIII; m_eEncoding = getConnection()->getTextEncoding(); } // ------------------------------------------------------------------------- -ODbaseTable::ODbaseTable(sdbcx::OCollection* _pTables,ODbaseConnection* _pConnection, - const OUString& _Name, - const OUString& _Type, - const OUString& _Description , - const OUString& _SchemaName, - const OUString& _CatalogName - ) : ODbaseTable_BASE(_pTables,_pConnection,_Name, - _Type, - _Description, - _SchemaName, - _CatalogName) - ,m_pMemoStream(NULL) - ,m_bWriteableMemo(sal_False) +ODbaseTable::ODbaseTable(sdbcx::OCollection* _pTables, ODbaseConnection* _pConnection, + const OUString& _Name, + const OUString& _Type, + const OUString& _Description , + const OUString& _SchemaName, + const OUString& _CatalogName ) + : ODbaseTable_BASE(_pTables,_pConnection,_Name, + _Type, + _Description, + _SchemaName, + _CatalogName) + , m_pMemoStream(NULL) + , m_bWriteableMemo(sal_False) { SAL_INFO( "connectivity.drivers", "dbase ocke.jans...@sun.com ODbaseTable::ODbaseTable" ); + m_aHeader = {}; m_eEncoding = getConnection()->getTextEncoding(); } commit 9e015c70cd3c84c07d23a7111917b8ba5c010e17 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 13:21:34 2014 -0600 coverity#707691 : Uninitialized scalar field Change-Id: I7bd74a8cb2b3cd5a57e960605816fc8373f8bae4 diff --git a/connectivity/source/drivers/dbase/DIndex.cxx b/connectivity/source/drivers/dbase/DIndex.cxx index 9a3562d..07d735e 100644 --- a/connectivity/source/drivers/dbase/DIndex.cxx +++ b/connectivity/source/drivers/dbase/DIndex.cxx @@ -72,11 +72,14 @@ ODbaseIndex::ODbaseIndex(ODbaseTable* _pTable) ODbaseIndex::ODbaseIndex( ODbaseTable* _pTable, const NDXHeader& _rHeader, const OUString& _rName) - :OIndex(_rName,OUString(),_rHeader.db_unique,sal_False,sal_False,sal_True) - ,m_pFileStream(NULL) - ,m_aHeader(_rHeader) - ,m_nCurNode(NODE_NOTFOUND) - ,m_pTable(_pTable) + : OIndex(_rName,OUString(),_rHeader.db_unique,sal_False,sal_False,sal_True) + , m_pFileStream(NULL) + , m_aHeader(_rHeader) + , m_nCurNode(NODE_NOTFOUND) + , m_nPageCount(0) + , m_nRootPage(0) + , m_pTable(_pTable) + , m_bUseCollector(sal_False) { construct(); } commit c6faf13222936ef3768dd6be1f3775a9d323f048 Author: Norbert Thiebaud <nthieb...@gmail.com> Date: Sat Feb 1 13:21:16 2014 -0600 coverity#707690 : Uninitialized scalar field Change-Id: Ie8df6f61610083afd46bccc3a1363e62f54a40db diff --git a/connectivity/source/drivers/dbase/DIndex.cxx b/connectivity/source/drivers/dbase/DIndex.cxx index d51fa57..9a3562d 100644 --- a/connectivity/source/drivers/dbase/DIndex.cxx +++ b/connectivity/source/drivers/dbase/DIndex.cxx @@ -56,13 +56,16 @@ using namespace com::sun::star::lang; IMPLEMENT_SERVICE_INFO(ODbaseIndex,"com.sun.star.sdbcx.driver.dbase.Index","com.sun.star.sdbcx.Index"); // ------------------------------------------------------------------------- -ODbaseIndex::ODbaseIndex(ODbaseTable* _pTable) : OIndex(sal_True/*_pTable->getConnection()->getMetaData()->supportsMixedCaseQuotedIdentifiers()*/) - ,m_pFileStream(NULL) - ,m_nCurNode(NODE_NOTFOUND) - ,m_pTable(_pTable) +ODbaseIndex::ODbaseIndex(ODbaseTable* _pTable) + : OIndex(sal_True/*_pTable->getConnection()->getMetaData()->supportsMixedCaseQuotedIdentifiers()*/) + , m_pFileStream(NULL) + , m_nCurNode(NODE_NOTFOUND) + , m_nPageCount(0) + , m_nRootPage(0) + , m_pTable(_pTable) + , m_bUseCollector(sal_False) { - m_aHeader.db_pagecount = m_aHeader.db_rootpage = m_aHeader.db_keytype = m_aHeader.db_maxkeys = m_aHeader.db_keylen = 0; - m_aHeader.db_name[0] = '\0'; + m_aHeader = {}; construct(); } // ------------------------------------------------------------------------- _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits