[Libreoffice-commits] core.git: oox/source

[Miklos Vajna]

 oox/source/shape/ShapeContextHandler.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit f4b15d214a00b514bce229bd3fcacb2b76757c6b
Author: Miklos Vajna <vmik...@collabora.co.uk>
Date:   Sat Apr 5 14:18:21 2014 +0200

    coverity#735766 Unchecked dynamic_cast
    
    Change-Id: I7f69e2a9d83d4632a23c6b1b15156b8e084487e2

diff --git a/oox/source/shape/ShapeContextHandler.cxx 
b/oox/source/shape/ShapeContextHandler.cxx
index 5c2aa70..57eb98b 100644
--- a/oox/source/shape/ShapeContextHandler.cxx
+++ b/oox/source/shape/ShapeContextHandler.cxx
@@ -420,6 +420,8 @@ ShapeContextHandler::getShape() throw 
(uno::RuntimeException, std::exception)
                 for (std::vector<OUString>::const_iterator aIt = 
mpShape->getExtDrawings().begin(); aIt != mpShape->getExtDrawings().end(); 
++aIt)
                 {
                     DiagramGraphicDataContext* pDiagramGraphicDataContext = 
dynamic_cast<DiagramGraphicDataContext*>(mxDiagramShapeContext.get());
+                    if (!pDiagramGraphicDataContext)
+                        break;
                     OUString 
aFragmentPath(pDiagramGraphicDataContext->getFragmentPathFromRelId(*aIt));
                     oox::drawingml::ShapePtr pShapePtr( new Shape( 
"com.sun.star.drawing.GroupShape" ) );
                     pShapePtr->setDiagramType();
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits