On Fri, Apr 25, 2014 at 03:07:58PM +0100, Markos Chandras wrote: > On Fri, Apr 25, 2014 at 09:27:29AM -0400, Paul Moore wrote: > > On Friday, April 25, 2014 11:49:42 AM Markos Chandras wrote: > > > On Thu, Apr 24, 2014 at 03:59:54PM -0400, Paul Moore wrote: > > > > On Wednesday, April 23, 2014 04:06:29 PM Markos Chandras wrote: > > > > > This test is for little endian architectures, so we rename it > > > > > to make that clear. This is in preparation for a new test, > > > > > identical to this one, which will test big-endian architectures. > > > > > > > > > > Signed-off-by: Markos Chandras <[email protected]> > > > > > > > > Have you tried this on a big endian MIPS system? I ask because I think > > > > you would need to remove the native architecture first like you do in > > > > the > > > > new big endian test. > > > > > > Hi Paul, > > > > > > No I haven't but you are right, it will probably not work. But I think > > > this > > > needs to be fixed in a separate patch, because all my patch does it to > > > rename the existing test. > > > > Agreed, a different patch is the best way to solve this problem. > > > > However, I'm more concerned that you haven't been testing on native MIPS > > systems; I thought you were. We've discussed this in the past and I'm > > relying > > on you to run these tests, as well as the "live" tests ('regression -T > > live'), > > on the different MIPS archs/ABIs. Without any verification of the full set > > of > > regression tests on the MIPS archs/ABIs I will be forced to remove MIPS > > code > > from libseccomp. > > > > -- > > paul moore > > security and virtualization @ redhat > > > > I didn't have the time to run the tests on big-endian systems in the past few > weeks. I did back when I submitted v1 but since then a lot of things have > changed. > At the moment, I am focusing on making the simulator work on x86_64 hosts so > most > people will not notice regressions. After that, I will move into introducing > live > tests for big-endian systems and run the test suite in BE and LE to see > what's left > to be fixed. Live tests pass fine on LE MIPS last time I tried. It's only big > endian that needs more testing after the recent changes, but like I said, I > thought fixing the simulator results was more important than providing live > tests. > > -- > markos
Hi Paul, Since I'd rather not see MIPS being removed so soon :) I ran the test suite on a big-endian machine: - live tests pass after fixing the 'regression' script to use the same return codes with mipsel. I will send a patch for this soon. - Most simulator tests pass except those adding little endian architectures to the filter (tests 16, 17, 19 and 23). Any prefered way to fix 17 and 19 tests properly or should I just duplicate them for big-endian? -- markos ------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ libseccomp-discuss mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libseccomp-discuss
