On Mon, 17 Oct 2011, Pavel Strashkin wrote:

I've also extended "_libssh2_error" with an ability to use formatting string as "_libssh2_debug" does.

Thanks a lot for your work, but...

Pretty please, do not make several unrelated changes in the same patch!

Your _libssh2_error() now returns a pointer to a stack based buffer which is completely wrong.

The comment header above libssh2_channel_signal() says the wrong function name.

--

 / daniel.haxx.se
_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel

Reply via email to