On Thursday 07 April 2011 21:32:44 you wrote: > Aris, Hi Mark, > OK, I'm working on the patch now. > > I noticed that I am listed as a developer in red.libssh.org. > Does that mean I have write access to git.libssh.org? > (If so, I'm gonna have to learn git.)
it just means that you have to fix bugs now ;) It is always a good idea to learn git especially for creating patches for libssh. We could prefer to have small commits for the scp stuff. It is easier to review and easier to find bugs (see 'git bisect'). git allows you to easily create a patch sent and mail it. http://book.git-scm.com/ If you need help with git just ask. > BTW, I attached a patch to the double-free bug: > https://red.libssh.org/issues/25 > > and marked it as "Fixed". I'm not sure I should have marked > it as fixed, because no one has actually applied the fix. > Just calling that to your attention. Please don't mark them as fixed. This is done by the person committing the patch to the repository. Thanks for your patch, I've committed it. Cheers, -- andreas -- Andreas Schneider GPG-ID: F33E3FC6 www.cryptomilk.org [email protected]
