Hi Andreas > Per Jakubs comments, I've pushed 1, 5, 6 and 8. In patch 7 your Sign-Off is > missing. Fixed patch 7 is attached.
> Do you plan to work on the things Jakub pointed out? Yes, I'm on it. Regards Tilo
From 825e96a88c534b4c9e336d16cdc0c766b59cb8db Mon Sep 17 00:00:00 2001 From: Tilo Eckert <[email protected]> Date: Thu, 15 Nov 2018 10:37:30 +0100 Subject: [PATCH 7/8] socket: Add missing braces Signed-off-by: Tilo Eckert <[email protected]> --- src/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/socket.c b/src/socket.c index 6012c46e..20831185 100644 --- a/src/socket.c +++ b/src/socket.c @@ -236,7 +236,7 @@ int ssh_socket_pollcallback(struct ssh_poll_handle_struct *p, (revents & POLLOUT) ? "POLLOUT ":"", (revents & POLLERR) ? "POLLERR":"", ssh_buffer_get_len(s->out_buffer)); - if (revents & POLLERR || revents & POLLHUP) { + if ((revents & POLLERR) || (revents & POLLHUP)) { /* Check if we are in a connecting state */ if (s->state == SSH_SOCKET_CONNECTING) { s->state = SSH_SOCKET_ERROR; -- 2.18.0
