On Monday, January 28, 2019 7:08:52 PM CET [email protected] wrote:
> It seems that I'm the only one using connectors. In the few samples I
> found it's only used to read/write from/to console. So the stdin and
> -out file handles don't need explicit close / EOF, hence the issue from
> above is not relevant.
>
> Now I also found what I think is a bug in the connector API. Anyone
> interested in this?
>
> Ok I guess I open a new "thread" on this - I also have a simple patch
> for it.
Hi Till,
the connector API has been implemented by Aris, I haven't looked deeply into
it. It works both on server and client however I don't think we have detailed
tests for it and this is probably the issue. We need test and test several
aspects of it in order to get it right. So if you have found a bug, it would
be great if you could add a test to reproduce it. Then fix it.
Once you have one test, most of the time it is easy to add another as you
already have the code and you can quickly find other issues and test the
corner cases.
Also it makes sure we don't break the functionality in future.
It would be great if you could look into that and provide patches.
Thanks,
Andreas
--
Andreas Schneider [email protected]
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D
