On Tuesday, 17 December 2019 06:48:01 CET Sebastian Kinne wrote: > Hi, > > > a) Could you please split the patch and put the pki_sha256() function into > > a separate commit? I would also use uint8_t instead of unsigend char in > > pki_sha256(). > > Done, please see attached. > > > b) Could you please add tests for this new features? See e.g. > > https://gitlab.com/libssh/libssh-mirror/commit/ > > 04b284dae02858b151ab75704eb15facf3781551
Could you please rebase on master and create a merge request on gitlab? It is easier to do reviews there. Thanks!
