Hi Dalibor,
* Dalibor Topic wrote on Thu, Apr 28, 2005 at 06:20:34PM CEST:
>
> here is another patch from Kaffe's libtool patch chest, which adds the
> missing braces around $sys_search_path in the definition of
> LTDL_SYSSEARCHPATH. That fixes libtool for at least one platform, though
> I don't recall which any more :(
That does not matter. I hate inconsistent macro option quoting, one
should do it even for the trivial cases just to get used to it, because
the times when an option should _not_ be quoted are very much exceptions
and should IMNSHO be clearly documented so.
I will send a patch regarding Autoconf documentation to the
autoconf-patches list, and have applied the attach patches to all three
libtool branches, which change all such invocations.
Many thanks for reporting all these bugs. Are there any other
libtool-related patches you have in kaffe? (The static *BSD dlopen bug
is still open, I don't know yet how to fix it.)
Regards,
Ralf
> 2004-03-12 Riccardo Mottola <[EMAIL PROTECTED]>,
> Michael Koch <[EMAIL PROTECTED]>
>
> * libltdl/acinclude.m4 (LTDL_SYSSEARCHPATH): Brace
> $sys_search_path argument.
2005-04-29 Ralf Wildenhues <[EMAIL PROTECTED]>
* ltdl.m4 (all over): Quote all arguments to AC_DEFINE and
AC_DEFINE_UNQUOTED consistently. Reported by
Michael Koch <[EMAIL PROTECTED]>, Riccardo Mottola <[EMAIL PROTECTED]>,
and Dalibor Topic <[EMAIL PROTECTED]>.
Index: m4/ltdl.m4
===================================================================
RCS file: /cvsroot/libtool/libtool/m4/ltdl.m4,v
retrieving revision 1.27
diff -u -r1.27 ltdl.m4
--- m4/ltdl.m4 4 Apr 2005 12:12:25 -0000 1.27
+++ m4/ltdl.m4 29 Apr 2005 08:44:04 -0000
@@ -39,7 +39,7 @@
if test "x$with_included_ltdl" = xno; then
# If the included ltdl is not to be used. then Use the
# preinstalled libltdl we found.
- AC_DEFINE([HAVE_LTDL], 1,
+ AC_DEFINE([HAVE_LTDL], [1],
[Define this if a modern libltdl is already installed])
LIBLTDL=-lltdl
fi
@@ -295,7 +295,7 @@
])
if test -n "$libltdl_cv_shlibext"; then
m4_pattern_allow([LT_MODULE_EXT])dnl
- AC_DEFINE_UNQUOTED(LT_MODULE_EXT, "$libltdl_cv_shlibext",
+ AC_DEFINE_UNQUOTED([LT_MODULE_EXT], ["$libltdl_cv_shlibext"],
[Define to the extension used for runtime loadable modules, say, ".so".])
fi
])# LT_SYS_MODULE_EXT
@@ -314,7 +314,7 @@
[lt_cv_module_path_var], [lt_cv_module_path_var="$shlibpath_var"])
if test -n "$lt_cv_module_path_var"; then
m4_pattern_allow([LT_MODULE_PATH_VAR])dnl
- AC_DEFINE_UNQUOTED(LT_MODULE_PATH_VAR, "$lt_cv_module_path_var",
+ AC_DEFINE_UNQUOTED([LT_MODULE_PATH_VAR], ["$lt_cv_module_path_var"],
[Define to the name of the environment variable that determines the
run-time module search path.])
fi
])# LT_SYS_MODULE_PATH
@@ -342,7 +342,7 @@
fi
done
m4_pattern_allow([LT_DLSEARCH_PATH])dnl
- AC_DEFINE_UNQUOTED(LT_DLSEARCH_PATH, "$sys_dlsearch_path",
+ AC_DEFINE_UNQUOTED([LT_DLSEARCH_PATH], ["$sys_dlsearch_path"],
[Define to the system default library search path.])
fi
])# LT_SYS_DLSEARCH_PATH
@@ -366,7 +366,7 @@
fi
])
if test x"$libltdl_cv_preloaded_symbols" = xyes; then
- AC_DEFINE(HAVE_PRELOADED_SYMBOLS, 1,
+ AC_DEFINE([HAVE_PRELOADED_SYMBOLS], [1],
[Define if libtool can extract symbol lists from object files.])
fi
])# _LT_CHECK_DLPREOPEN
@@ -534,7 +534,7 @@
fi
if test x"$libltdl_cv_need_uscore" = xyes; then
- AC_DEFINE(NEED_USCORE, 1,
+ AC_DEFINE([NEED_USCORE], [1],
[Define if dlsym() requires a leading underscore in symbol names.])
fi
])# LT_FUNC_DLSYM_USCORE
