Hi!
(Using a real MUA for a change...)
* Ralf Wildenhues wrote on Sunday, September 25, 2005 15:10 CEST:
> * Peter Ekberg wrote on Thu, Sep 22, 2005 at 12:43:46PM CEST:
> > * Ralf Wildenhues wrote on Thursday, September 22, 2005 10:06 CEST:
> > > * Peter Ekberg wrote on Thu, Sep 22, 2005 at 10:00:32AM CEST:
> > > > But looking closer, include_expsyms is a disaster area. Since it
> > > > isn't used, my vote is to zap it completely.
> > > >
> > > > The problem is that it potentially clobbers user provided files,
> > > > so that building repeatedly will eat up all your disk space
> > > > eventually (but that isn't the worst problem with clobbering
> > > > user provided files of course).
> > >
> > > Why not make a copy of the user-provided file and append to that?
> > > C'mon, that isn't rocket science. Unless there are other reasons
> > > against include_expsyms, that is.
> >
> > Well, it seemed to complicate matters for little reason, that's all.
>
> That's just because you try to avoid any extra copy, which requires
> quite some logic, as seen in your proposed patch.
I you don't mind the extra copy, here's a patch which does that instead.
> > Ok, here's a patch. I renamed the orig_export_symbols variable
> > as it's now not always the original export_symbols value...
>
> I tried hard to find an error in the patch, but failed.
> Please install, I think it's ok.
Yes, I tested thoroughly, it was a mess.
* libltdl/config/ltmain.m4sh (func_mode_link): Don't modify
user provided symbols file.
Cheers,
Peterr
Index: libltdl/config/ltmain.m4sh
===================================================================
RCS file: /cvsroot/libtool/libtool/libltdl/config/ltmain.m4sh,v
retrieving revision 1.10
diff -u -r1.10 ltmain.m4sh
--- libltdl/config/ltmain.m4sh 22 Sep 2005 07:46:08 -0000 1.10
+++ libltdl/config/ltmain.m4sh 27 Sep 2005 11:22:01 -0000
@@ -4932,6 +4932,11 @@
# Use standard objects if they are pic
test -z "$pic_flag" && libobjs=`$ECHO "X$libobjs" | $SP2NL | $Xsed -e
"$lo2o" | $NL2SP`
+ if test -n "$export_symbols"; then
+ $opt_dry_run || cp "$export_symbols" "$output_objdir/$libname.uexp"
+ export_symbols="$output_objdir/$libname.uexp"
+ fi
+
orig_export_symbols=
case $host_os in
cygwin* | mingw*)
