Le 19 janv. 09 à 23:38, Ralf Wildenhues a écrit :

Bonjour Ralf!


It is true that I have been disturbed and even annoyed by tab vs.
space in some patches that gave the impression of improper
indentation.

Therefore, for a year or so, I am now using spaces only.

But it is not sufficient for Libtool if you are the only one who uses
spaces.

I was actually promoting the space-only approach for the libtool
coding style, not claiming that I would do it regardless of the
decision :)

And it is probably not helpful for email readability if new
lines are spaces and old lines are tabs for indentation.

Transitions are always a PITN, but it's for a better future :)

Well, changing Libtool over to use spaces only is quite a diff, and not
a trivial one to check, either.

Agreed, but it can be done incrementally.  Or we can start
by converting all the leading spaces, I fail to see a reason
for a tab to be required there.

Let alone that it increases ltmain.sh
by more than 10% in size, which will probably even have an impact on
runtime performance.

Hum...

From 425171194b41e6627aae75f18dfa5620e8a8c34d Mon Sep 17 00:00:00 2001
From: Akim Demaille <demai...@gostai.com>
Date: Mon, 19 Jan 2009 09:05:31 +0100
Subject: [PATCH] Clean space uses.

        * libtoolize.m4sh: Remove trailing spaces.
        Use <tab><sp>, as some editors remove "useless" spaces in
        <sp><tab>.

This patch is ok, feel free to push.

Will do, thanks.

Reply via email to