On 06/14/2010 03:01 PM, Ralf Wildenhues wrote:
>> +eval `$EGREP '^(old_library)=' < $libdir/libbar.la`
> 
> This is probably lacking double-quoting around the `...` text.  Can you
> verify?

For that matter, it's not safe in the presence of signals, since some
shells end up doing "eval ''" if the `` is interrupted.  You want:

str=`$EGREP '^(old_library)=' < $libdir/libbar.la`
eval "$str"

or possibly even "$libdir" in the first line to be robust to spaces in
file names.

-- 
Eric Blake   ebl...@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to