* Charles Wilson wrote on Mon, Aug 02, 2010 at 05:23:28AM CEST: > The "unexpected" failure was > 112: override pic_flag at configure time FAILED (pic_flag.at:48) > which isn't a regression on cygwin.
I'm pushing this patch to fix two issues with the test case. Really should've known better than to use grep -e ... Thanks for the report, Ralf Fix pic_flag test unportabilities. * tests/pic_flag.at (override pic_flag at configure time): Skip test if the compiler produces a warning containing `fpic'. Do not use nonportable `grep -e', for Solaris. Report by Charles Wilson. diff --git a/tests/pic_flag.at b/tests/pic_flag.at index a729d16..e62e1b7 100644 --- a/tests/pic_flag.at +++ b/tests/pic_flag.at @@ -34,7 +34,9 @@ int func(void) { return data; } cp foo.c foo.cpp C_pic_flag='-fpic -DPIC' AT_CHECK([$CC $CPPFLAGS $CFLAGS $C_pic_flag -c foo.c || exit 77], - [], [ignore], [ignore]) + [], [stdout], [stderr]) +# The configure test for the PIC flag also checks for warnings. +AT_CHECK([grep fpic stdout stderr && exit 77], [1]) CXX_pic_flag='-fpic -DPIC' if $CXX $CPPFLAGS $CXXFLAGS $CXX_pic_flag -c foo.cpp; then :; else @@ -46,6 +48,6 @@ AT_CHECK(["$abs_top_srcdir"/configure lt_cv_prog_compiler_pic="$C_pic_flag" ]dnl : ${MAKE=make} AT_CHECK([$MAKE], [], [stdout], [ignore]) AT_CHECK([if ./libtool --features | grep 'enable shared libraries'; then ]dnl - [ grep -e -fpic stdout; else exit 77; fi], [], [ignore], [ignore]) + [ grep ' -fpic' stdout; else exit 77; fi], [], [ignore], [ignore]) AT_CLEANUP