* Ralf Wildenhues wrote on Mon, Aug 09, 2010 at 08:50:55PM CEST:
> I think Libtool should use Autobuild, <http://josefsson.org/autobuild/>,
> for testing, and developers as well as users should be encouraged to
> send results to the gathering site.  It's about time I try to get my
> various build setups sorted out in some manner suitable for that.

OK to commit?

The AB_INIT invocation causes something like this extra info to appear
in the configure output:

configure: autobuild project... GNU Libtool
configure: autobuild revision... 2.2.11a (1.3227 2010-08-09)
configure: autobuild hostname... fuchs
configure: autobuild mode... default
configure: autobuild timestamp... 20100822T183040Z

When you don't have autobuild installed, thus AB_INIT not defined,
the patch should be a no-op.  autobuild will still be usable without
the above output, it's just that the developer then needs to explicitly
provide the information as command-line arguments to autobuild.

I'd rather avoid adding libltdl/m4/autobuild.m4 to our git, that might
introduce version conflicts in the future.

A better long-term solution would be to start using gnulib-tool (for
argz, autobuild, maybe eventually bootstrap), but I *really* don't want
to start experimenting with that option before the release.

Thanks,
Ralf

    configure: use Autobuild AB_INIT if available.
    
    * configure.ac: Call AB_INIT if it is defined, with
    $autobuild_mode as argument, to be set at configure time.
    Set AB_VERSION to the Libtool version string.
    * HACKING: Update.
    * libltdl/m4/.gitignore: Ignore autobuild.m4.

diff --git a/HACKING b/HACKING
index 7ea1818..19b4b66 100644
--- a/HACKING
+++ b/HACKING
@@ -601,7 +601,9 @@ or obtained by writing to the Free Software Foundation, 
Inc.,
   (esp. bug-libtool) for outstanding bug reports also in the list of
   pending moderation requests.
 
-* Make sure you have wget and lzma installed.
+* Make sure you have wget, lzma, and autobuild installed.  aclocal should be
+  able to find autobuild.m4; or you can install it into the tree with
+         aclocal -I libltdl/m4 --install
 
 * Make sure your locale is sane, e.g. by exporting LC_ALL=C.
 
@@ -717,8 +719,8 @@ or obtained by writing to the Free Software Foundation, 
Inc.,
   which will automatically propogate to http://planet.gnu.org.
 
 -- 
-  Copyright (C) 2004, 2005, 2006, 2007, 2008 Free Software Foundation,
-  Inc.
+  Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Free Software
+  Foundation, Inc.
   Written by Gary V. Vaughan, 2004
 
   This file is part of GNU Libtool.
diff --git a/configure.ac b/configure.ac
index 35c79f1..9690a05 100644
--- a/configure.ac
+++ b/configure.ac
@@ -127,6 +127,19 @@ dnl These are bootstrap requirements! Once built, libtool 
may work with
 dnl much older releases of autoconf and automake.  See release notes.
 AM_INIT_AUTOMAKE([1.10.1 gnu subdir-objects dist-lzma])
 
+
+## ------------------------- ##
+## Autobuild initialisation. ##
+## ------------------------- ##
+
+# You can set autobuild_mode at configure time to specify a "unique"
+# string for this build.
+: ${autobuild_mode=default}
+AB_VERSION="AC_PACKAGE_VERSION ($TIMESTAMP)"
+m4_ifdef([AB_INIT],
+        [AB_INIT([$autobuild_mode])])
+
+
 dnl We use m4sh to generate libtool's portable shell scripts
 AC_SUBST([M4SH], ['$(AUTOM4TE) --language=m4sh'])
 
diff --git a/libltdl/m4/.gitignore b/libltdl/m4/.gitignore
index 0b52c5c..81a1059 100644
--- a/libltdl/m4/.gitignore
+++ b/libltdl/m4/.gitignore
@@ -1 +1,2 @@
 ltversion.m4
+autobuild.m4

Reply via email to