* Gary V. Vaughan wrote on Wed, Sep 01, 2010 at 04:42:52AM CEST: > On 1 Sep 2010, at 01:16, Ralf Wildenhues wrote: > > * Gary V. Vaughan wrote on Tue, Aug 31, 2010 at 08:43:20AM CEST: > >> -test -f clcommit.m4sh && $MAKE -f Makefile.maint ./commit \ > >> - srcdir=. top_srcdir=. PACKAGE="$package" VERSION="$version" \ > >> - M4SH="$AUTOM4TE -l m4sh" \ > >> - SED="$SED" GREP="$GREP" FGREP="$FGREP" EGREP="$EGREP" LN_S="$LN_S" > >> +func_show_eval "$MAKE bootstrap-deps \ > >> +M4SH='$AUTOM4TE --language=m4sh' PACKAGE='$package' \ > >> +PACKAGE_BUGREPORT='$package_bugreport' PACKAGE_NAME='$package_name' \ > >> +PACKAGE_URL='$package_url' SED='$SED' srcdir=. VERSION='$version'" > > > > For bootstrap, the func_show_eval from the rejected patch is probably > > gotten just as easily by just 'set -x'; besides the fact that using eval > > on this string is wrong. > > I was under the impression that the following were equivalent (with the > former removing the opportunity for two near copies of the same complex > invocation to get out of sync): > > func_show_eval "$MAKE bootstrap-deps M4SH='$AUTOM4TE --language=m4sh' ...." > > and: > > echo "$MAKE bootstrap-deps M4SH='$AUTOM4TE --language=m4sh' ..." > $MAKE bootstrap-deps M4SH='$AUTOM4TE --language=m4sh' ..." > > What am I missing?
You are right on that one; sorry about that. Of course, func_show_eval is still buggy in that it causes more filename expansion than we'd like to have (leading to commits like v2.2.10-48-g3ab9879), but yes, that shouldn't be an issue here. Cheers, Ralf