* Peter Rosin wrote on Mon, Sep 06, 2010 at 09:34:02PM CEST: > Den 2010-09-06 20:42 skrev Ralf Wildenhues: > > * Peter Rosin wrote on Mon, Sep 06, 2010 at 08:38:31PM CEST: > >> I think I want to do > >> > >> + func_to_tool_file "$output_objdir/" > >> + tool_output_objdir=$func_to_tool_file_result > >> > >> and > >> > >> + $CC -o $output_objdir/$soname $libobjs $compiler_flags $deplibs > >> "@$tool_output_objdir$soname.exp" -Wl,-DLL~ > > > > I'm not sure why you replace the second $output_objdir/ instance but not > > the first one in this line? > > I'm not sure it's a good reason, but there is zero chance of this > code path in libtool working without 'compile'. The first conversion > is handled by 'compile' and as a rule of thumb I have converted as > late as possible.
I think as a general rule that is fine, but here ... > Maybe libtool is faster at converting though, > since it doesn't need to look up what conversion to perform? ... not just that: it has already converted the exact same string before, namely $tool_output_objdir. Adding this: > From a correctness POV, it doesn't matter. I think you should just reuse the result you already have, here. Thanks, Ralf
