Den 2010-09-17 18:53 skrev Ralf Wildenhues: > let the review sprint begin ...
Sorry for the late patches... > Hi Peter, > > * Peter Rosin wrote on Fri, Sep 17, 2010 at 04:18:55PM CEST: >> I noticed that -DDLL_EXPORT didn't appear when I compiled C++ code >> with MSVC. >> >> I'd like this one to go in before the release. >> >> Ok to push? > > OK, thanks. Pushed. Thanks! > Testsuite exposure would be nice at some point. Yes. It would, I guess exceptions.at will cover it if I get that to work. > In this macro, there are 4 cases, with the first criterion being decided > at autoconf time, the second at configure time: > 1) $1 = CXX $CXX = yes > 2) $1 = CXX $CXX != yes > 3) $1 != CXX $GCC = yes > 4) $1 != CXX $GCC != yes > > your code fixes case (2). After the change, the mingw bits of > the cases (1) and (2) both superfluously compare $1 to GCJ; that is > not needed, because $1 is CXX. You may simplify both cases accordingly. There's also the cegcc in the $GCC = yes case, which looks like a paradox. I didn't want to touch that at this stage though. Cheers, Peter
