On 09/01/2011 09:25 AM, Bob Friesenhahn wrote:
On Mon, 29 Aug 2011, Peter O'Gorman wrote:
This turns off warnings for --silent (and turns them on again for
--verbose).
But I am not sure that --silent was meant to imply "no warnings",
rather it turns off the verbose compile/link messages.
Would a new --no-warnings option be more appropriate?
I agree that a new option would be more appropriate. However, it should
be a user-provided configuration option (when building the package) and
not something which will be hard-coded into Makefiles by developers. The
--silent option should have been handled the same so that the person
building the software can easily decide if the build should be silent.
Hi Bob,
Well, it has to be an option that Dave can add to site.exp for the
failing tests in gcc. The tests are failing on HP-UX because libtool is
outputing "this platform does not like uninstalled shared libraries"
crap to stderr.
Though I am sorely tempted to simply delete those warnings altogether, I
think the --no-warn option is better.
I'll give you a day to veto this patch, if you don't then I will commit
on Saturday. It essentially copies the --no-warn flag from libtoolize to
libtool.
Peter
>From dc28c2bfbcb4879bc04a73186d72ec0e7ef2ad4c Mon Sep 17 00:00:00 2001
From: Peter O'Gorman <pe...@pogma.com>
Date: Thu, 1 Sep 2011 18:45:03 -0500
Subject: [PATCH] Add flag to inhibit warnings.
* libltdl/config/ltmain.m4sh: Add --no-warn, --no-warning flags.
Reported by John Davd Anglin.
---
ChangeLog | 6 ++++++
libltdl/config/ltmain.m4sh | 3 +++
2 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index dcfab26..44b325b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2011-09-01 Peter O'Gorman <pe...@pogma.com>
+
+ Add flag to inhibit warnings.
+ * libltdl/config/ltmain.m4sh: Add --no-warn, --no-warning flags.
+ Reported by John Davd Anglin.
+
2011-04-10 Kurt Roeckx <k...@roeckx.be>
tagdemo: do not rely on picking up symbols from indirect deps.
diff --git a/libltdl/config/ltmain.m4sh b/libltdl/config/ltmain.m4sh
index 9358ec5..511480f 100644
--- a/libltdl/config/ltmain.m4sh
+++ b/libltdl/config/ltmain.m4sh
@@ -42,6 +42,7 @@ m4_divert_push([SCRIPT])
# --quiet, --silent don't print informational messages
# --no-quiet, --no-silent
# print informational messages (default)
+# --no-warn don't display warning messages
# --tag=TAG use configuration variables from tag TAG
# -v, --verbose print more informational messages than default
# --no-verbose don't print the extra informational messages
@@ -373,6 +374,8 @@ M4SH_GETOPTS(
esac],
[], [--no-silent|--no-quiet], [false], [
func_append preserve_args " $opt"],
+ [], [--no-warning|--no-warn], [false], [
+ func_append preserve_args " $opt"],
[], [--no-verbose], [false], [
func_append preserve_args " $opt"],
[], [--silent|--quiet], [], [
--
1.7.4.4
