Taking advantage of more of the nice development tools that gnulib gives us, this series of patches gradually fixes problems flagged by the builtin `make syntax-check' tests, re-enabling the newly passing checks as it goes.
There's nothing really controversial in here anywhere, but I won't push for at least another 72 hours in the hope of getting more eyes on them, since some of the changes are quite broad and sweeping. I don't have any fortran compilers (or any clue about how to read or write fortran code!!), and while I did apply the advice of some of these checks to fortran sources, and check with google that I wasn't trying to do anything obviously illegal, I would appreciate it if anyone reading this could apply the series and check that the fortran tests still work. If you'd like me to roll you a dist tarball with everything already applied, please ask. It goes without saying that `make distcheck' is still working correctly on at least my machine with this entire series applied. * cfg.mk (local-checks-to-fix): Move sc_unmarked_diagnostics from here... (local-checks-to-skip): ...to here. Signed-off-by: Gary V. Vaughan <g...@gnu.org> --- cfg.mk | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 99dada0..22de32c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -57,7 +57,6 @@ local-checks-to-fix = \ sc_require_config_h_first \ sc_space_tab \ sc_trailing_blank \ - sc_unmarked_diagnostics \ sc_useless_cpp_parens local-checks-to-skip = \ @@ -68,12 +67,14 @@ local-checks-to-skip = \ sc_cast_of_argument_to_free \ sc_cast_of_x_alloc_return_value \ sc_error_message_uppercase \ - sc_program_name + sc_program_name \ + sc_unmarked_diagnostics # GPL_version: checks for GPLv3, which we don't use -# avoid_if_before_free: we don't use the gnulib malloc modules # bindtextdomain: libtool isn't internationalized +# avoid_if_before_free: we don't use the gnulib malloc modules # cast_of_argument_to_free: ditto # cast_of_x_alloc_return_value: ditto # error_message_uppercase: we like our error messages # program_name: libtool has no programs! +# unmarked_diagnostics: libtool isn't internationalized -- 1.7.7.3 Cheers, -- Gary V. Vaughan (gary AT gnu DOT org)