Hi Pavel,
> On Nov 22, 2014, at 7:28 AM, Pavel Raiskup <prais...@redhat.com> wrote:
>
> On Friday 21 of November 2014 19:31:51 Gary V. Vaughan wrote:
>> Starting slowly, your first patch conflates two separate changes. The
>> first of those bringing back the correct use of LT_LIB_DLLOAD so that
>> LIBADD_DL is set correctly for Makefile.in.
>>
>> That seems slightly wrong to me, because master has not used libltdl for
>> a while. I've added the macro, but instead of removing LIBADD_DL from
>> the link libraries, I removed LIBLTDL.
>
> ACK for LIBLTDL removal from m4_libm4_la_LIBADD. However to my previous
> patch this is different change.
>
> This is nit, but I removed the LIBADD_DL in hope that it is not needed;
> LT_LIB_DLLOAD already puts '-ldl' into LIBS for me:
I think that's a bug. 2 bugs in fact:
1. LIBADD_DL is not documented, so M4 should be using LIBADD_DLOPEN.
2. LT_LIB_DLLOAD is not restoring LIB to its pristine state after calling
AC_SEARCH_LIBS, so the additional `-ldl` should not be there.
> /bin/sh ./libtool --tag=CC --mode=link gcc -std=gnu99 -O0 -g3 -pipe
> -no-undefined -export-dynamic -export-symbols-regex ".*" -o
> m4/libm4.la -rpath /usr/local/lib m4/builtin.lo m4/debug.lo m4/hash.lo
> m4/input.lo m4/m4.lo m4/macro.lo m4/module.lo m4/output.lo m4/path.lo
> m4/resyntax.lo m4/symtab.lo m4/syntax.lo m4/utility.lo
> m4/gnu/libgnu.la -ldl -ldl
>
> ^^^^^^^^^^
I'm testing patches for both, though you'll still see the duplicate -ldl
in the link line except when rebootstrapping with master (and imminent
2.4.4) libtool.
Cheers,
--
Gary V. Vaughan (gary AT gnu DOT org)
_______________________________________________
https://lists.gnu.org/mailman/listinfo/libtool
