On 31/05/2024 17:47, Joakim Tjernlund wrote:
On Thu, 2024-05-30 at 18:10 +0300, Ileana Dumitrescu wrote:On 29/05/2024 16:27, Joakim Tjernlund wrote:Ping ?On Wed, 2024-01-31 at 19:53 +0200, Ileana Dumitrescu wrote:On 31/01/2024 17:15, Joakim Tjernlund wrote:Has some variant of https://lists.gnu.org/archive/html/libtool-patches/2022-04/msg00010.html been discussed/considered ? JoakimThe patchset seems good, and that particular patch was most likely forgotten about. I'll look through the thread and the older mailing list discussions and see what the concerns were. I'm currently waiting to do an alpha, so I wouldn't merge it in and/or fix it until after that. On an unrelated note, while looking at the patches I discovered the interesting mix of spaces and tabs throughout ltmain.in. Somehow, I'd previously missed that. -- Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354Sorry, I forgot about this. Now, it has been tested and applied to the development branch.Thanks, I just noted that Gentoo also has added lt_sysroot for the yes = $hardcode_minus_L case: --- ltmain.sh +++ ltmain.sh @@ -8367,7 +8367,7 @@ test no = "$hardcode_direct_absolute"; then add=$libdir/$linklib elif test yes = "$hardcode_minus_L"; then - add_dir=-L$libdir + add_dir=-L$lt_sysroot$libdir add=-l$name elif test yes = "$hardcode_shlibpath_var"; then case :$finalize_shlibpath: in @@ -8384,7 +8384,7 @@ fi else # We cannot seem to hardcode it, guess we'll fake it. - add_dir=-L$libdir + add_dir=-L$lt_sysroot$libdir # Try looking first in the location we're being installed to. if test -n "$inst_prefix_dir"; then case $libdir in You may want to do the same ? Joakim
Thank you! I am adding this missing case, since it looks correct. -- Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354
OpenPGP_0x6570EA01146F7354.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
