On Tue, 21 Jan 2014 07:43:10 -0700, Nathan Hjelm said:

>> (2) os/darwin_usb.c:531:10: Implicit conversion loses integer
>precision: 'size_t' (aka 'unsigned long') to 'int'
>> 
>> A cast would silence this, but actually I worry the last line of the
>function is returning entirely the wrong thing.  Shouldn't it return
>'ret' not 'len'?  The docs for 'get_config_descriptor' say 'Return 0 on
>success or a LIBUSB_ERROR code on failure.'
>> 
>> 
>> (3) core.c:1163:7: Use of memory after it is freed
>> 
>> This could be a false positive as it's from the static analyzer.  It's
>code path dependant, and really you need the Xcode GUI to follow the
>flow.  Nathan, could you look?
>
>I will take a look at both 2 and 3 today.

Nathan,

Just wanted to ping you on these.  Both issues still exist in master.

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 s...@rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada



------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel

Reply via email to