On Fri, Jan 11, 2013 at 4:00 AM, Ludovic Rousseau <ludovic.rouss...@gmail.com> wrote: > 2013/1/10 Jie Zhang <jzhang...@gmail.com>: >> I think we should move this #pragma closer to the place where it's >> used. Otherwise user program will need the same thing to disable the >> warning. > > Move #pragma from msvc/config.h to libusb/libusb.h ? > I am against this change. The #pragma is for Windows so should be in a > Windows only file. > If msvc/config.h is installed and included automatically in libusb.h when compiled by MSVC, I will have no problem. But we only install libusb.h. So every user file of libusb.h needs to add the pragma to suppress the warning with MSVC.
> Or maybe add a #ifdef WIN32 (or similar) so it is a Windows only > configuration? We sure need something like that. But not WIN32, which is an OS thing. We need _MSC_VER, which is a compiler thing. Regards, Jie ------------------------------------------------------------------------------ Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and much more. Get web development skills now with LearnDevNow - 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122812 _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
