On 09/01/13 00:34, Pete Batard wrote: > 1. in .gitignore, there's a !wince/listdevs entry. Shouldn't there be > similar entries for xusb and test? Also what does the 'STANDARDSDK_500 > (*)' entry do?
> 2. I see you using both a WINCE and _WIN32_WCE define. Is there a > difference between the two? If not, maybe it'd make sense to just pick > one and try to stick to it. Also, if a file tends to use #if defined() > rather than #ifdef, it's probably worth carrying the trend (looking at > the #ifndef WINCE at the top of libusb.h) > 4. Ideally, instead of using #ifdef WIN_CE in the core source, we'd > probably want to emulate the HAS_SYS_TYPE_H, HAS_SIGNAL_H functionally > from autoconf in the msvc's config.h. We're already populating some of > these values on anything POSIX, and can add the missing ones if needed, > so I might just do that during integration. Of course, we can't use the > HAS_#### values in all files (libusb.h and the samples/tests come to > mind, as they don't rely on config.h), but it would probably help making > our code look a bit more conventional. I've done 1, 2 and 4 in my branch now. I've also applied your patches. I believe that all your review comments are covered. Let me know if you have further feedback or I've misunderstood one of your comments. Regards, Toby ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
