On 2013.01.29 19:38, Ludovic Rousseau wrote: > Signedness issues are very hard to fix correctly without changing the > public API (and without using explicit casts)
Yeah. Note that if you can think of good changes to add for the API, you can add it to the API-2.0 page [1]. > It is then easier to find a bug using "git bisect" for example. Notwithstanding that 1&2 haven't been merged, you're seriously trying to tell me that this ([2]) and this ([3]), that equate to 2 one-liners that are exact clone of each other and that pertain to the exact same file for the exact same warning, are better left separated, and that I should spend twice the amount of time merging them, in the expectation that someone, somewhere, is unlikely to figure their way out of git-bisect, unless they are split? Well, my spare time is limited, and easing up the life of some very hypothetical libusbx git-bisect users (who by the way, have been awfully silent on this mailing list the few times they could have demonstrated their git-bisect skills on possible libusbx regressions) will have to come second to my ability of conducting maintenance of a project that comes with very limited resources and in what I see as the most efficient manner (i.e. the one that leaves us with the most time to conduct matters that may be helpful to libusbx users as a whole, rather than just the ones with a git granularity fetish). So here's the new rule: If I'm the one to apply a set patches that pertain to fixing the same kind of issue (such as very similar warnings, no matter if peppered across multiple files), and the cumulative number of lines patches is less than 10, I'm going to reject that patchset wholesale, unless it is provided as a single diff/patch file. Now, of course, if somebody else wants to take upon them the burden of having to apply that set to mainline, they are free to do so (as long as they don't break nano-versioning). But personally, I'm not planning to waste any more of my time on a "more-granular-than-thou" endeavour, especially when I haven't seen any tangible benefits for it. > Thanks for merging the code. You're welcome. Regards, /Pete [1] https://github.com/libusbx/libusbx/wiki/API-2.0 [2] https://github.com/LudovicRousseau/libusbx/commit/14b3528dff66bad6554d9db93079f2bd67d443a2 [3] https://github.com/LudovicRousseau/libusbx/commit/1866b670dac5b376041d3d16ff062139e1580dbf ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
