2013/6/8 Pete Batard <p...@akeo.ie>: > On 2013.06.08 16:39, Ludovic Rousseau wrote: >> If you don't want to invest more time than needed then just provide >> the missing MSVC and mingw changes. >> But you _also_ had time to rewrite a working code. > > Indeed. The choice was: Do I want to leave libusbx with a solution that > will make it more difficult for translators to add messages (but with > the advantage of sparing some of my free time), or do I instead make the > effort to write code that will be straightforward for us to maintain and > ensure that we get more translations. > > There's also the problem of duplicating the same switch all over the > place. If you're gonna end up with 10 or 20 time the same switch > statement, you really oughta look into factorizing your code.
I prefer Hans code even if it uses a switch per language. I find it more maintainable and easy to understand. I find your code more complex and dangerous. Hans already explained why for some aspects of it. Do we need to vote to select the code that will be used? Bye -- Dr. Ludovic Rousseau ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
