Hi Martin, Thanks for your reply!
On 08/02/2013 09:28 AM, Martin Pieuchot wrote: > On 02/08/13(Fri) 13:23, Xiaofan Chen wrote: >> On Tue, Jul 30, 2013 at 11:38 PM, Hans de Goede <hdego...@redhat.com> wrote: >>> Hi Martin, >>> >>> On 07/16/2013 11:32 AM, Martin Pieuchot wrote: >>>> Hello Hans and Pete, >>>> >>>> You'll find below an update for OpenBSD's libusb backend, freshly >>>> rebased on top of the last libusb/libusbx release. >>>> >>>> I sent it twice to Peter Stuge but it never get committed after we >>>> addressed all the issues he raised. Could you push it in the main >>>> repository? It has been packaged on OpenBSD for some months now. >>>> >>> >>> Thanks for the patch. We certainly will add this to the master repo, >>> I'm not sure about the timing though. It turns out 1.0.16 has a nasty >>> deadlock on exit, so we want to do a 1.0.17 with this fixed fairly soon. >>> >>> Thus it might be better delaying merging this post 1.0.17, OTOH this >>> is isolated to just the openbsd support, and as you say yourself, >>> openbsd itself it already shipping with this commit so it may be >>> good to actually get it into 1.0.17. >>> >>> Pete, what do you think ? >> >> Maybe you want to post the patch to get Pete and others to >> review of the patch. >> >> I think if it is isolated for OpenBSD, it can be merged into >> 1.0.17. Since we use the same code for NetBSD, we may >> want to carry out tests under NetBSD as well. > > I'm quite sure it will not work for NetBSD, we added new interfaces to > the kernel to fulfil libusb's requirements. Hmm, then I'm afraid we cannot take the patch as is. Could you add #ifdef-s to retain the old behavior when not build on openbsd ? I'm not expecting you to actually test on netbsd, but a patch which on paper will work on netbsd would be a good start. It is also proably best then to merge this post 1.0.17 (which will be a small bug-fix only release we hope to release soon), assuming you can provide an updated patch getting this into 1.0.18 should not be a problem. Regards, Hans ------------------------------------------------------------------------------ Get your SQL database under version control now! Version control is standard for application code, but databases havent caught up. So what steps can you take to put your SQL databases under version control? Why should you start doing it? Read more to find out. http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
