Looks good to me too. I will build the rc tomorrow. -Nathan
On Aug 8, 2013, at 7:09 PM, Pete Batard <p...@akeo.ie> wrote: > On 2013.08.08 18:35, Toby Gray wrote: >> I've attached a rebase of patches 1 to 4 onto the master branch of libusbx. > > Thanks. Much appreciated. > > I have now merged 1&2 and pushed it. > > Besides merging, the changes I added are: > - Use the W facility for both CE and regular Windows. The thing is, if > you're using anything above win2k, W is what Windows uses internally > anyway, so it's not gonna hurt us any > - Use CP_ACP rather than CP_UTF8, first because anything that's not > Unicode MUST DIE, and second because me way one day want to send Unicode > data using our existing facilities (regardless of whether DebugView is > Unicode compliant or not). > - Add a warning for builds that enabled --enable-system-log but don't > have an OS logging facility. From what I gather, #warning is used by all > the compilers we support, except MSVC, which means we should be fine. > And yeah, I know we're duplicating the fputs() line, which we could > probably factorize, but it's behind exclusive #ifdefs, so this kind of > optimization won't matter one bit. > - Added a UNUSED() guard for level, since I was picking a warning in > VS2012 because of it. > - Harmonized the way we reported defaults in configure.ac, since it was > all over the place, and the standard that autotools seem to use is > "[default=yes/no]". Looks more streamlined that way. > > Normally, I'd wait 24 hours for review for something like this, but > since we're gearing up towards RC, and I wouldn't mind finding out early > if we broke any system, I just pushed it. Of course, I ran tests with > the usual suspects (VS, WDK, cygwin, Linux) and everything looked fine. > > Oh, and this new logging is very very cool, especially with the syslog > facility added. Pretty sure some of our Linux users will be very glad to > have this new capability. > > I'll try to look at the Android patches tomorrow, unless someone is in a > better position to test them, coz I sure don't have any such capability atm. > > Regards, > > /Pete > > ------------------------------------------------------------------------------ > Get 100% visibility into Java/.NET code with AppDynamics Lite! > It's a free troubleshooting tool designed for production. > Get down to code-level detail for bottlenecks, with <2% overhead. > Download for free and get started troubleshooting in minutes. > http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk > _______________________________________________ > libusbx-devel mailing list > libusbx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/libusbx-devel ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
