2013/8/23 Xiaofan Chen <xiaof...@gmail.com>
> On Sat, Aug 24, 2013 at 12:44 AM, Juan Lang <juanl...@google.com> wrote:
> > 2013/8/22 Xiaofan Chen <xiaof...@gmail.com>
> >> Again I agree with you. On the other hand, I think it is still good
> >> if Juan can come out a version for review. I do not mind review and
> >> carry out some testing myself.
> >
> > Thanks Xiaofan. Is emailing a diff to the list or creating a pull request
> > the appropriate means of getting a review?
>
> Both methods are okay. But a pull request in Github may be
> easier.
Thanks. Sent.
It's not as scary as it looks, but I thought I'd first send one big patch
to show where it's headed. If it's easier I can break it up into several
different patches, something like:
1. Move initializing a device from a USB_NODE_CONNECTION_INFORMATION_EX to
a helper function.
2. Defer reading the device and config descriptors from GEN_PASS to
DEV_PASS.
3. For WinUsb devices, fall back to WinUsb
when IOCTL_USB_GET_NODE_CONNECTION_INFORMATION_EX fails.
4. For WinUsb devices, use WinUsb to read a device's config descriptor.
Let me know if you'd prefer that I split this up, and by all means give
feedback. Thanks,
--Juan
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel
