Hi, On 09/15/2013 04:27 AM, Xiaofan Chen wrote: > On Fri, Sep 6, 2013 at 10:52 PM, Hans de Goede <hdego...@redhat.com> wrote: >> Signed-off-by: Hans de Goede <hdego...@redhat.com> >> --- >> libusb/core.c | 2 +- >> libusb/libusbi.h | 4 ++-- >> libusb/os/darwin_usb.c | 6 +----- >> libusb/os/linux_usbfs.c | 5 ++++- >> libusb/os/netbsd_usb.c | 4 +--- >> libusb/os/openbsd_usb.c | 4 +--- >> libusb/os/wince_usb.c | 1 - >> libusb/os/windows_usb.c | 26 +++++++++++++++----------- >> libusb/version_nano.h | 2 +- >> 9 files changed, 26 insertions(+), 28 deletions(-) >> ... >> diff --git a/libusb/os/darwin_usb.c b/libusb/os/darwin_usb.c >> index 889c62a..d0350fb 100644 >> --- a/libusb/os/darwin_usb.c >> +++ b/libusb/os/darwin_usb.c >> @@ -293,6 +293,7 @@ static void darwin_devices_detached (void *ptr, >> io_iterator_t rem_devices) { >> /* signal the core that this device has been disconnected. the >> core will tear down this device >> when the reference count reaches 0 */ >> usbi_disconnect_device(dev); >> + usb_unref_device(dev); > > I think this should be libusb_unref_device(dev); > > This commit breaks Darwin build. > > os/darwin_usb.c: In function 'darwin_devices_detached': > os/darwin_usb.c:296: error: implicit declaration of function > 'usb_unref_device' > make[2]: *** [os/libusb_1_0_la-darwin_usb.lo] Error 1
Oops, you're right. I've just pushed a fix for this. Regards, Hans ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel