On Tue, Sep 04, 2007 at 05:21:41PM +0100, Richard W.M. Jones wrote: > > # virsh dumpxml solaris32fv > libvir: Xen Daemon error : failed Xen syscall xenDaemonDomainDumpXML > domain ID < 0 and xendConfigVersion < 3 0 > [ and dump proceeds as normal ] > > The patch just removes the false error message and makes a note that > this still needs a real fix later.
I understand the patch, but I disagree with removing the comment explaining the returned value for xenDaemonDomainDumpXMLByName() You ask to dump the XML for an inactive domain, on xen < 3.1 you can't do this there, maybe you don't want to see an error being raised but still the way the function works didn't changed, so keep that comment please :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
