On Tue, Mar 18, 2008 at 10:05:48AM -0400, Cole Robinson wrote: > Jim Meyering wrote: > > Cole Robinson <[EMAIL PROTECTED]> wrote: > >> The attached patch implements the following operations for the qemu driver: > > ... > >> + qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_DOMAIN, > >> + "no domain with matching uuid '%s'", dom->uuid); > > ... > >> + qemudReportError(dom->conn, dom, NULL, VIR_ERR_INVALID_ARG, > >> + "cannot set max memory lower than current > >> memory"); > > ... > > > > Hi Cole. > > The patch looks good. > > Please put _(...) around diagnostics, so that they end up being translated. > > Fixed patch attached.
Looks fine, +1 Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ [EMAIL PROTECTED] | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/ -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
