On Wed, Aug 27, 2008 at 11:48:27AM +0100, Richard W.M. Jones wrote: > On Mon, Aug 25, 2008 at 01:41:24PM -0400, Cole Robinson wrote: > > Originally, ejecting a cdrom from a qemu guest entailed > > passing 'eject cdrom' to the monitor. But since qemu > > added the -drive option, more than one cdrom can be > > specified, so just using 'cdrom' isn't explicit enough. > > > > The attached patch updates media change/eject to use > > the current qemu syntax. The new generated commands > > look something like "eject ide0-cd1", with the name > > derived from device target and bus type. > > I'm a bit unclear -- will this break for people using older versions > of qemu/kvm?
Looks very much like it will. If we're lucky this change in monitor syntax occurred at the time the -drive command was introduced. In which case its easy to conditionalize based on the whether that's in use or not. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :| -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
