Hi, Daniel This proposal seems approved. Does this proposal message goes to somewhere in libvirt document?
Thanks Atsushi SAKAI Daniel Veillard <[EMAIL PROTECTED]> wrote: > As the number of compilation options and platform grows, it gets > more difficult for a commiter to always ensure one chunk of code > won't give a problem in a different situation. To try to lower the > cost of maintaining the protability I would suggest the following > rule for commit: > - if a recently commited patch breaks compilation on a platform > or for a given driver then it's fine to commit a minimal fix > directly without getting the review feedback first > - similary if make check or make syntax-chek breaks, if there is > an obvious fix, it's fine to commit immediately > Note that this would remove the need to send the patch to the list > anyway (or tell what the fix was if trivial). This doesn't either > remove the rule that 'make check syntax-check' should pass before > commiting anything, and obviously the existing review process is still > needed t for anything which is not a trivial fix breaking make or > checks. > > I guess it makes sense to minimize disruption for those working on > head and lower the time needed to get those fix in for those who catch > and fix them ;-) > Opinions ? > > Daniel > > -- > Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ > [EMAIL PROTECTED] | Rpmfind RPM search engine http://rpmfind.net/ > http://veillard.com/ | virtualization library http://libvirt.org/ > > -- > Libvir-list mailing list > Libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
