Chris Lalancette wrote: > As suggested by danpb, to fix up the regression caused by last week's VIR_ENUM > cleanup patch, add a ".defaultFormat" member to .poolOptions. In > storage_conf.c, if virXPathString(/pool/source/format/@type) returns NULL, > then > set the pool type to .defaultFormat; otherwise, lookup the type via > formatFromString. > > Signed-off-by: Chris Lalancette <[EMAIL PROTECTED]> > >
Thanks, this fixed a segfault I was seeing if defining a disk pool with no format. ACK. One side effect of this patch is that now disk xml can have <format type="unknown"/>, which isn't a doc'd value. Something for the future though. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
