Cedric, Am 27.08.2014 09:33, schrieb Cedric Bosdonnat: > Hi Richard, > > On Tue, 2014-08-26 at 22:32 +0200, Richard Weinberger wrote: >> On Tue, Aug 26, 2014 at 3:20 PM, Cédric Bosdonnat <cbosdon...@suse.com> >> wrote: >>> Hi all, >>> >>> Here is the whole series resent with a major addition: the functions >>> used to set the IP and add a route now use libnl when possible. The idea >>> behind this is to avoid requiring iproute2 or ifconfig installed in the >>> container rootfs. >> >> What about my comments on v1? > > Entering only the network NS would have a larger impact on the container > initialization code and we would still need to have iproute2/ifconfig > installed in the container... and nothing guarantees that will be true.
no, you can use the tools from the _host_ side. Because you're only entering the network namespace, not the mount namespace. > OTOH, we are pretty sure we'll have rtnetlink support in the kernel. > > And if for some reason we don't have libnl at build time, the old code > using iproute2/ifconfig will still be used. > > I went with a libnl implementation based on Laine's advise on IRC. Okay. I'm not a huge fan of reimplementing iproute2 in libvirt but.... Thanks, //richard -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
