On 08/27/2014 04:54 PM, John Ferlan wrote: > I almost didn't want to do this due to the sheer volume, but figured > at the very least the bulk of these are resource leaks found by the > much pickier new coverity scanner. > > After this there are "only" 70 issues found... > > John Ferlan (19): > libxl_migration: Resolve Coverity NULL_RETURNS > daemon: Resolve Coverity NEGATIVE_RETURNS > domain_conf: Resolve Coverity RESOURCE_LEAK > cpu_x86: Resolve Coverity RESOURCE_LEAK > qemu_command: Resolve Coverity RESOURCE_LEAK > qemu_agent: Resolve Coverity RESOURCE_LEAK > libxl_domain: Resolve Coverity RESOURCE_LEAK > qemu_capabilities: Resolve Coverity RESOURCE_LEAK > network_conf: Resolve Coverity RESOURCE_LEAK > virsh-network: Resolve Coverity RESOURCE_LEAK > bridge_driver: Resolve Coverity RESOURCE_LEAK > libxl_migration: Resolve Coverity RESOURCE_LEAK > phyp_driver: Resolve Coverity RESOURCE_LEAK > qemu_driver: Resolve Coverity RESOURCE_LEAK > storage_conf: Resolve Coverity RESOURCE_LEAK > qemu_monitor: Resolve Coverity NESTING_INDENT_MISMATCH > domain_conf: Resolve Coverity DEADCODE > qemu_driver: Resolve Coverity DEADCODE > qemu_command: Resolve Coverity DEADCODE > > daemon/remote.c | 24 ++++++++++++------------ > src/conf/domain_conf.c | 28 ++++++++++++++++++++++++---- > src/conf/network_conf.c | 2 ++ > src/conf/storage_conf.c | 2 ++ > src/cpu/cpu_x86.c | 15 ++++++++++----- > src/libxl/libxl_domain.c | 4 +++- > src/libxl/libxl_migration.c | 11 +++++++++-- > src/network/bridge_driver.c | 1 + > src/phyp/phyp_driver.c | 1 + > src/qemu/qemu_agent.c | 6 ++++-- > src/qemu/qemu_capabilities.c | 2 +- > src/qemu/qemu_command.c | 9 +++++---- > src/qemu/qemu_driver.c | 8 ++++++++ > src/qemu/qemu_monitor.c | 3 ++- > tools/virsh-network.c | 2 +- > 15 files changed, 85 insertions(+), 33 deletions(-) >
I removed patch 1 (letting Jim handle it) I modified patch 3 (or now 2) to use virDomainVcpuPinDefFree() I have pushed the series. Thanks for the quick review - John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
