On 09/05/14 00:26, John Ferlan wrote: > Coverity notes that if qemuMonitorGetMachines() returns a negative > nmachines value, then the code at the cleanup label will have issues. > > Signed-off-by: John Ferlan <jfer...@redhat.com> > --- > src/qemu/qemu_capabilities.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c > index 854a9b8..a652f29 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -2285,7 +2285,7 @@ virQEMUCapsProbeQMPMachineTypes(virQEMUCapsPtr qemuCaps, > size_t defIdx = 0; > > if ((nmachines = qemuMonitorGetMachines(mon, &machines)) < 0) > - goto cleanup; > + return -1;
Also nmachines doesn't need to be initialized. > > if (VIR_ALLOC_N(qemuCaps->machineTypes, nmachines) < 0) > goto cleanup; > ACK
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
