On 10/22/2014 11:14 AM, Daniel P. Berrange wrote:
> Introduce a src/libvirt-network.c file to hold all the
> methods related to the virNetwork type.
> ---
>  docs/apibuild.py      |    1 +
>  po/POTFILES.in        |    1 +
>  src/Makefile.am       |    2 +
>  src/libvirt-network.c | 1251 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  src/libvirt.c         | 1221 -----------------------------------------------
>  5 files changed, 1255 insertions(+), 1221 deletions(-)
>  create mode 100644 src/libvirt-network.c
> 

> +++ b/src/libvirt-network.c

> +
> +VIR_LOG_INIT("libvirt.network");
> +
> +#define VIR_FROM_THIS VIR_FROM_NONE
> +

Same comment as in 3/12 - do we want to update this to be more specific
than VIR_FROM_NONE?

Otherwise, I did the same review as mentioned in 2/12; it is just code
motion.

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to