On Tue, Oct 28, 2014 at 10:49 AM, Daniel P. Berrange
<berra...@redhat.com> wrote:
> I understand you created separate bhyvebootloader vs xenbootloader
> schema rules, so that the Xen case can keep <bootloader> as compulsory
> for use when <bootloader_args> is set, while for bhyve you allow
> <bootloader_args> without any corresponding <bootloader>.
>
> The actual XML parser meanwhile, always allows <bootloader_args>
> even when <bootloader> is not set. So I think you don't really
> need to have the complexity of making the schema provide different
> rules for xen vs bhyve.
>
> Lets just stay simple and keep a single <define name="bootloader"/>element
> and make the <bootloader> optional to match what the parser actually
> does.

Sure, sounds reasonable to me. I'll fix it in the next submission.

Thanks,
Conrad

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to