On Fri, Nov 7, 2014 at 4:56 PM, Michal Privoznik <mpriv...@redhat.com> wrote: > On 29.10.2014 13:15, Matthias Gatto wrote: >> >> This series of patches add support for bps_max, bps_rd_max, bps_wr_max, >> bps_max, bps_rd_max, bps_wr_max, and iops_size in the functions >> qemuDomainSetBlockIoTune >> and qemuDomainGetBlockIoTune. >> The last patch add support for these parameters to the virsh blkdeviotune >> command. >> >> v2: -Spellfix >> >> v3: -Merge patch 1/9,2/9,5/9 together. >> -Change the capability detection.(patch 2/7 and 3/7). >> -Try to make the usage of QEMU_NB_BLOCK_IO_TUNE_PARAM_MAX more >> explicit(patch 3/7). >> >> v4: -Rebase on HEAD. >> -Update qemu_driver to comply with Pavel's patchs.(patch 3/6) >> -Remove the qemu_monitor_text modification.(remove old patch 5/7) >> >> v5: -Split patch 1/6 in two. >> -Add documentation for the new xml options (patch 2/7) >> -Change (void) to ATTRIBUTE_UNUSED (patch 4/7) >> -Capability detection of supportMaxOptions move before usage of >> supportMaxOptions (patch 4/7) >> >> v6: -Spellfix >> -Add comment (patch 4/7, 5/7) >> -Undo the modification of the supportMaxOptions made >> in the v5 because it was creating bugs(patch 4/5) >> >> The 2 first patches have been reviewed by Eric Blake and sould be merge >> soon >> The 3rd patch have been reviewed by Michal Privoznik and ack >> >> Matthias Gatto (7): >> qemu: Add define for the new throttle options >> qemu: Modify the structure _virDomainBlockIoTuneInfo. >> qemu: Add Qemu capability for bps_max and friends >> qemu: Add bps_max and friends qemu driver >> qemu: Add bps_max and friends QMP suport >> qemu: Add bps_max and friends to qemu command generation >> virsh: Add bps_max and friends to virsh >> >> docs/formatdomain.html.in | 25 ++++ >> docs/schemas/domaincommon.rng | 43 ++++++ >> include/libvirt/libvirt-domain.h | 110 ++++++++++++++++ >> src/conf/domain_conf.c | 109 +++++++++++++++- >> src/conf/domain_conf.h | 7 + >> src/qemu/qemu_capabilities.c | 2 + >> src/qemu/qemu_capabilities.h | 1 + >> src/qemu/qemu_command.c | 57 +++++++- >> src/qemu/qemu_driver.c | 187 >> ++++++++++++++++++++++++++- >> src/qemu/qemu_monitor.c | 10 +- >> src/qemu/qemu_monitor.h | 6 +- >> src/qemu/qemu_monitor_json.c | 66 ++++++++-- >> src/qemu/qemu_monitor_json.h | 6 +- >> tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + >> tests/qemumonitorjsontest.c | 6 +- >> tools/virsh-domain.c | 119 +++++++++++++++++ >> tools/virsh.pod | 10 ++ >> 17 files changed, 732 insertions(+), 33 deletions(-) >> > > > So, I've reviewed the patches. They seem okay except for a few minor things > I've found. I don't want to force you to send another version, so can you > send just a follow-up patch? Well, 1/7 and 6/7 is easily fixable so I'll do > that myself. However, 4/7 requires a bit more of work. So I'm okay with you > sending follow-up patch just for that one. > > Partial ACK for now. > > Michal
Thank for the review. I send the patch as soon as I fix it. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
